fix(query): allow CloudFormation DB security group /24 CIDRs#8057
Open
omribz156 wants to merge 1 commit into
Open
fix(query): allow CloudFormation DB security group /24 CIDRs#8057omribz156 wants to merge 1 commit into
omribz156 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7988
Reason for Proposed Changes
/24CIDRs as larger than 256 hosts./24has exactly 256 addresses, so it should not match the query description: "must not have more than 256 hosts."Proposed Changes
/24are reported./24negative fixtures for both inline and standalone CloudFormation ingress resources./23positive fixtures as the more-than-256-hosts coverage.Verification
go test ./test -run "TestQueries/cloudFormation/aws/db_security_group_open_to_large_scope" -count=1git diff --check(passed with local CRLF warnings only)This was implemented with Codex assistance, with the final patch kept focused and manually reviewed.
I submit this contribution under the Apache-2.0 license.