Skip to content

feat: nv28 upgrade mainnet#7037

Merged
LesnyRumcajs merged 1 commit into
mainfrom
firehorse-mainnet-prepare
May 12, 2026
Merged

feat: nv28 upgrade mainnet#7037
LesnyRumcajs merged 1 commit into
mainfrom
firehorse-mainnet-prepare

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented May 12, 2026

Summary of changes

Changes introduced in this pull request:

  • Set the mainnet NV28 FireHorse network upgrade epoch to 6052800 which corresponds to Wed May 27 02:00:00 PM UTC 2026.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

https://filecoinproject.slack.com/archives/C05P37R9KQD/p1778518210802829?thread_ts=1778508150.666689&cid=C05P37R9KQD

Summary by CodeRabbit

  • Chores
    • Added support for the FireHorse (NV28) network upgrade scheduled for mainnet at epoch 6052800 (May 27, 2026).
    • Updated actor bundle metadata and state migration configurations for the upcoming upgrade.

Review Change Stack

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner May 12, 2026 16:09
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team May 12, 2026 16:09
@LesnyRumcajs LesnyRumcajs enabled auto-merge May 12, 2026 16:09
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6eabfa8a-8307-47ca-a71a-5274d8ec5fd3

📥 Commits

Reviewing files that changed from the base of the PR and between 64bc264 and 6eb136b.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • build/manifest.json
  • src/networks/actors_bundle.rs
  • src/networks/mainnet/mod.rs
  • src/state_migration/mod.rs

Walkthrough

This PR activates the NV28 FireHorse network upgrade on mainnet by configuring the activation epoch to block 6052800, registering the v18.0.0 actor bundle with its manifest CIDs, and wiring the state migration to execute at that height.

Changes

NV28 FireHorse Mainnet Activation

Layer / File(s) Summary
Network upgrade configuration and bundle registration
build/manifest.json, src/networks/actors_bundle.rs, src/networks/mainnet/mod.rs
The v18.0.0 actor bundle manifest is registered with all actor CIDs. The HEIGHT_INFOS map is updated to set FireHorse at epoch 6052800 with the v18.0.0 bundle reference, replacing the previous i64::MAX placeholder.
State migration wiring and documentation
src/state_migration/mod.rs, CHANGELOG.md
The nv28::run_migration is added to the mainnet migration pipeline at Height::FireHorse. The upgrade epoch and version are documented in the changelog.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • ChainSafe/forest#6942: Introduces FireHorse height in network height mappings with similar code-level changes to src/networks/mainnet/mod.rs.
  • ChainSafe/forest#7003: Updates v18 actor bundle entries and FireHorse HEIGHT_INFOS configuration for a different network (butterflynet).
  • ChainSafe/forest#6921: Implements the nv28 module and run_migration function that this PR wires into the migration pipeline.

Suggested labels

Release

Suggested reviewers

  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: nv28 upgrade mainnet' directly and clearly summarizes the main change: implementing the NV28 (FireHorse) network upgrade for mainnet with a specific epoch configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firehorse-mainnet-prepare
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch firehorse-mainnet-prepare

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.17%. Comparing base (64bc264) to head (6eb136b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/networks/actors_bundle.rs 90.35% <100.00%> (+0.04%) ⬆️
src/networks/mainnet/mod.rs 100.00% <100.00%> (ø)
src/state_migration/mod.rs 81.31% <100.00%> (+0.20%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64bc264...6eb136b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into main with commit 42965ad May 12, 2026
43 checks passed
@LesnyRumcajs LesnyRumcajs deleted the firehorse-mainnet-prepare branch May 12, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants