Skip to content

refactor: msg pool to make more structured part 3#7033

Draft
akaladarshi wants to merge 3 commits into
akaladarshi/msgpool-refactor-phase2from
akaladarshi/msgpool-refactor-phase3
Draft

refactor: msg pool to make more structured part 3#7033
akaladarshi wants to merge 3 commits into
akaladarshi/msgpool-refactor-phase2from
akaladarshi/msgpool-refactor-phase3

Conversation

@akaladarshi
Copy link
Copy Markdown
Collaborator

@akaladarshi akaladarshi commented May 11, 2026

Summary of changes

Changes introduced in this pull request:

This PR is part 3 of restructuring of msg pool, it contains:

  • Use Arc on MessagePool itself rather than each individual field, this will allow us to:
    • Pass the message pool directly into the head-change trigger which will become part of the MessagePool, instead of being a free function with unlimited params
    • Convert republish_cycle part of the MessagePool, instead of being a free function with unlimited params
    • Make all the message pool related free fn part of the Message pool methods:
      • head_change -> apply_head_change
      • republish_pending_messages -> run_republish_cycle
      • add_helper -> add_to_pool_unchecked
      • add_tipset -> add_to_pool

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 308e3a10-36e8-4444-a8c6-e79368fc11da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch akaladarshi/msgpool-refactor-phase3
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch akaladarshi/msgpool-refactor-phase3

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant