Fix close for mixed mode edges (#1477)

* Fix close for mixed mode edges

* black fix

* Logic fix

* Add a test

---------

Co-authored-by: adam-urbanczyk <13981538+adam-urbanczyk@users.noreply.github.com>

Author: adam-urbanczyk

cadquery/sketch.py

@@ -775,7 +775,14 @@ def _startPoint(self) -> Vector:
         if not self._edges:
             raise ValueError("No free edges available")
 
-        e = self._edges[0]
+        # find the first edge matching current edge mode
+        e = self._edges[-1]
+        mode = e.forConstruction
+
+        for el in self._edges:
+            if el.forConstruction == mode:
+                e = el
+                break
 
         return e.startPoint()
 

tests/test_sketch.py

@@ -973,3 +973,22 @@ def test_missing_selection(s1):
     # cannot tag without selection
     with raises(ValueError):
         s1.tag("name")
+
+
+def test_mixed_close():
+
+    # check that closing of mixed mode edges works correctly
+    s = (
+        Sketch()
+        .arc((0, 0), 30, 0, 120, tag="e0", forConstruction=True)
+        .edges(tag="e0")
+        .distribute(1, rotate=False)
+        .segment((0, 0), (10, 2))
+        .segment((10, -2))
+        .close()
+        .assemble()
+        .reset()  # reset the implicit selection coming from distribute
+    )
+
+    # the underlying face should be valid
+    assert s.val().isValid()