Fixes possible incorrect mapping between eai metric values and exposure points in trajectories#1297
Open
spjuhel wants to merge 1 commit into
Open
Fixes possible incorrect mapping between eai metric values and exposure points in trajectories#1297spjuhel wants to merge 1 commit into
spjuhel wants to merge 1 commit into
Conversation
spjuhel
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
peanutfun
reviewed
Jun 17, 2026
peanutfun
left a comment
peanutfun
left a comment
Member
There was a problem hiding this comment.
Looks reasonable. But are there no tests for the results?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
calc_eai_gdf(both for static and interpolated trajectories) where the exposure points coordinates are incorrectly mapped to the corresponding risk value when the exposureGeoDataFrameindex is discontinuous.The suggested fix directly uses the index, instead of creating it from a range.
PR Author Checklist
develop)PR Reviewer Checklist