Add configurable Dask frame execution with SLURM-backed HPC support#354
Open
harryswift01 wants to merge 22 commits into
Open
Add configurable Dask frame execution with SLURM-backed HPC support#354harryswift01 wants to merge 22 commits into
harryswift01 wants to merge 22 commits into
Conversation
…d-parallelisation
…d-parallelisation
jimboid
requested changes
Jun 3, 2026
Member
jimboid
left a comment
There was a problem hiding this comment.
This PR looks very complete. The code additions to core functionality look like they are in line with the parallel version I wrote in the water-entropy code. It looks like the code has been sufficiently adapted to this code base with complete and thorough treatment of parameter handling. Documentation looks complete and detailed, the tests look detailed and complete like on the WE implementation. I don't see any surprises with the HPC set up logic, however we should not leave this to chance. In such a PR I would like to see the following data/screenshots or have someone verify the following points (since unit tests only go so far when there is an element of infrastructure involved):
- Performance characterisation difference for serial implementation and parallel implementation for a local run. Total execution time is sufficient for say 20 - 50 frames.
- Testing that the submission script on a known hpc platform is generated correctly for any automatic submission mode
- Testing that the auto submission and conda detection machinery is working correctly and that the dask scheduler is submitted correctly.
- That the performance data for a single node is inline and likely much stronger than those in point 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds configurable parallel frame-by-frame execution to CodeEntropy using Dask, with support for both local Dask workers and SLURM-backed HPC execution. It also adds runtime submission support for SLURM master jobs, validates the new parallel/HPC configuration options, and updates the documentation to explain the new arguments and parallel execution modes.
Changes
Parallel frame execution:
LevelDAG.Local Dask and SLURM/HPC configuration:
parallel_frames,use_dask,dask_workers, anddask_threads_per_worker.hpc,submit,hpc_queue,hpc_nodes,hpc_cores,hpc_processes,hpc_memory,hpc_walltime,hpc_account,hpc_qos,hpc_constraint,conda_path,conda_exec, andconda_env.HPCDaskManagerfor configuring SLURM-backed Dask clusters and generating/submitting master SLURM scripts.submit=True, allowing CodeEntropy to submit a master SLURM job and exit before starting local analysis.Tests and documentation:
LevelDAGtests into a single test file to reduce duplication.Impact