Skip to content

🎨 Formatting#15

Merged
QzLP2P merged 1 commit intomainfrom
tgi/feat/format
Jan 19, 2026
Merged

🎨 Formatting#15
QzLP2P merged 1 commit intomainfrom
tgi/feat/format

Conversation

@QzLP2P
Copy link
Copy Markdown
Collaborator

@QzLP2P QzLP2P commented Jan 19, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 19, 2026 11:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request changes variable declarations from implicit typing (var) to explicit typing (IVaultService) for mock objects created with Substitute.For<IVaultService>() in test methods.

Changes:

  • Changes 5 variable declarations from var vaultService = Substitute.For<IVaultService>() to IVaultService vaultService = Substitute.For<IVaultService>() across multiple test methods

{
// Arrange
var vaultService = Substitute.For<IVaultService>();
IVaultService vaultService = Substitute.For<IVaultService>();
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.

Copilot uses AI. Check for mistakes.
{
// Arrange
var vaultService = Substitute.For<IVaultService>();
IVaultService vaultService = Substitute.For<IVaultService>();
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.

Copilot uses AI. Check for mistakes.
{
// Arrange
var vaultService = Substitute.For<IVaultService>();
IVaultService vaultService = Substitute.For<IVaultService>();
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.

Copilot uses AI. Check for mistakes.
{
// Arrange
var vaultService = Substitute.For<IVaultService>();
IVaultService vaultService = Substitute.For<IVaultService>();
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.

Copilot uses AI. Check for mistakes.
{
// Arrange
var vaultService = Substitute.For<IVaultService>();
IVaultService vaultService = Substitute.For<IVaultService>();
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.

Copilot uses AI. Check for mistakes.
@QzLP2P QzLP2P merged commit 4621639 into main Jan 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants