Conversation
There was a problem hiding this comment.
Pull request overview
This pull request changes variable declarations from implicit typing (var) to explicit typing (IVaultService) for mock objects created with Substitute.For<IVaultService>() in test methods.
Changes:
- Changes 5 variable declarations from
var vaultService = Substitute.For<IVaultService>()toIVaultService vaultService = Substitute.For<IVaultService>()across multiple test methods
| { | ||
| // Arrange | ||
| var vaultService = Substitute.For<IVaultService>(); | ||
| IVaultService vaultService = Substitute.For<IVaultService>(); |
There was a problem hiding this comment.
This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.
| { | ||
| // Arrange | ||
| var vaultService = Substitute.For<IVaultService>(); | ||
| IVaultService vaultService = Substitute.For<IVaultService>(); |
There was a problem hiding this comment.
This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.
| { | ||
| // Arrange | ||
| var vaultService = Substitute.For<IVaultService>(); | ||
| IVaultService vaultService = Substitute.For<IVaultService>(); |
There was a problem hiding this comment.
This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.
| { | ||
| // Arrange | ||
| var vaultService = Substitute.For<IVaultService>(); | ||
| IVaultService vaultService = Substitute.For<IVaultService>(); |
There was a problem hiding this comment.
This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.
| { | ||
| // Arrange | ||
| var vaultService = Substitute.For<IVaultService>(); | ||
| IVaultService vaultService = Substitute.For<IVaultService>(); |
There was a problem hiding this comment.
This change is inconsistent with the project's .editorconfig settings. The .editorconfig specifies csharp_style_var_when_type_is_apparent = true:suggestion, which means var should be preferred when the type is apparent from the right-hand side of the assignment. Since Substitute.For<IVaultService>() makes the type apparent, the original var declaration aligns better with the project's coding standards. Additionally, this creates inconsistency within the same file where other declarations like var builder = new ConfigurationBuilder() still use var for apparent types.
No description provided.