-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(DockView2): bump version 10.0.8-beta06 #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
344f611
2e4a327
967f46f
85a26c2
fce3d3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ namespace BootstrapBlazor.Components; | |
| /// <para lang="zh">DockViewV2 组件</para> | ||
| /// <para lang="en">DockViewV2 component</para> | ||
| /// </summary> | ||
| public partial class DockViewV2 : IDisposable | ||
| public partial class DockViewV2 | ||
| { | ||
| /// <summary> | ||
| /// <para lang="zh">获得/设置 DockView 名称,默认为 null,用于本地存储标识</para> | ||
|
|
@@ -413,20 +413,18 @@ internal void UpdateComponentState(string? key, bool visible, bool? isLock) | |
| return state; | ||
| } | ||
|
|
||
| private void Dispose(bool disposing) | ||
| /// <summary> | ||
| /// <inheritdoc/> | ||
| /// </summary> | ||
| /// <param name="disposing"></param> | ||
| /// <returns></returns> | ||
| protected override ValueTask DisposeAsync(bool disposing) | ||
| { | ||
| if (disposing) | ||
| { | ||
| ThemeProviderService.ThemeChangedAsync -= OnThemeChangedAsync; | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// <inheritdoc/> | ||
| /// </summary> | ||
| public void Dispose() | ||
| { | ||
| Dispose(true); | ||
| GC.SuppressFinalize(this); | ||
| return base.DisposeAsync(disposing); | ||
|
Comment on lines
424
to
+428
|
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
IDisposablefrom the publicDockViewV2type is a breaking API change for any consumers that were relying onDockViewV2being disposable (e.g., storing it asIDisposable). If the goal is to switch to the base class async dispose pattern, consider preserving compatibility by keepingIDisposableon the public surface (or providing an explicitIDisposable.Disposethat forwards to the async dispose path), or document this as an intentional breaking change for the beta bump.