feat(BaiduSpeech): remove HttpClient MemoryCache services inject#891
Merged
feat(BaiduSpeech): remove HttpClient MemoryCache services inject#891
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the BaiduSpeech component DI setup by no longer registering HttpClient and MemoryCache directly in its AddBootstrapBlazorBaiduSpeech extension, leaving only the Baidu speech-specific services to be wired up. Class diagram for updated BaiduSpeech DI extensionclassDiagram
class ServiceCollectionExtension {
+IServiceCollection AddBootstrapBlazorBaiduSpeech(IServiceCollection services, Action_BaiduSpeechOption configOptions)
}
class IServiceCollection
class RecognizerService
class IRecognizerProvider
class BaiduRecognizerProvider
IServiceCollection <|.. ServiceCollectionExtension
IServiceCollection o--> RecognizerService : scoped
IServiceCollection o--> IRecognizerProvider : scoped
IRecognizerProvider <|.. BaiduRecognizerProvider
class BaiduSpeechOption
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary service registrations (AddHttpClient() and AddMemoryCache()) from the BaiduSpeech component's dependency injection setup and bumps the version from 10.0.1 to 10.0.2.
- Removes
AddHttpClient()andAddMemoryCache()calls that are not required by the BaiduSpeech component - Updates package version to 10.0.2
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ServiceCollectionExtension.cs | Removes unnecessary HttpClient and MemoryCache service registrations from the BaiduSpeech DI configuration |
| BootstrapBlazor.BaiduSpeech.csproj | Increments package version from 10.0.1 to 10.0.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #890
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: