Skip to content

feat(UniverSheet): bump version 10.0.6 #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 4 commits into from
Dec 30, 2025
Merged

feat(UniverSheet): bump version 10.0.6 #881

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30eb9b1
chore(univerSheet): update univer to v0.15.0
zhaijunlei955 Dec 30, 2025
05f6be0
refactor: 精简代码
ArgoZhang Dec 30, 2025
43e7dec
chore: bump version 10.0.6
ArgoZhang Dec 30, 2025
824133b
Merge branch 'master' into feat-univer
ArgoZhang Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/BootstrapBlazor.UniverSheet/BootstrapBlazor.UniverSheet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.0.5</Version>
<Version>10.0.6</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
8 changes: 6 additions & 2 deletions src/components/BootstrapBlazor.UniverSheet/wwwroot/univer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { addScript, addLink, getTheme } from '../BootstrapBlazor/modules/utility.js'
import { addScript, addLink, getTheme } from '../BootstrapBlazor/modules/utility.js'
import DataService from './data-service.js'

const loadAssets = async lang => {
const loadAssets2 = async lang => {
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name loadAssets2 is unclear and doesn't follow good naming conventions. If this function is being kept for a specific reason (such as backward compatibility, debugging, or as an alternative loading strategy), it should have a more descriptive name like loadAssetsIndividually, loadAssetsLegacy, or loadAssetsUnbundled to clarify its purpose.

Copilot uses AI. Check for mistakes.
await addScript('./_content/BootstrapBlazor.UniverSheet/univer/react.production.min.js');
await addScript('./_content/BootstrapBlazor.UniverSheet/univer/react-dom.production.min.js');
await addScript('./_content/BootstrapBlazor.UniverSheet/univer/rxjs.umd.min.js');
Expand All @@ -26,6 +26,10 @@ const loadAssets = async lang => {
await addLink('./_content/BootstrapBlazor.UniverSheet/univer/univer-sheet.bundle.css');
}

const loadAssets = async lang => {
await addScript('./_content/BootstrapBlazor.UniverSheet/univer/univer-bundle.js');
await addLink('./_content/BootstrapBlazor.UniverSheet/univer/univer-sheet.bundle.css');
}
export async function createUniverSheetAsync(sheet) {
sheet.lang = sheet.lang ?? 'en-US';
await loadAssets(sheet.lang);
Comment on lines +29 to 35
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new loadAssets function no longer uses the lang parameter that is passed to it (line 35: await loadAssets(sheet.lang);). This parameter should either be removed from the function signature if it's not needed, or the localization files should be loaded appropriately in the bundled approach.

Suggested change
const loadAssets = async lang => {
await addScript('./_content/BootstrapBlazor.UniverSheet/univer/univer-bundle.js');
await addLink('./_content/BootstrapBlazor.UniverSheet/univer/univer-sheet.bundle.css');
}
export async function createUniverSheetAsync(sheet) {
sheet.lang = sheet.lang ?? 'en-US';
await loadAssets(sheet.lang);
const loadAssets = async () => {
await addScript('./_content/BootstrapBlazor.UniverSheet/univer/univer-bundle.js');
await addLink('./_content/BootstrapBlazor.UniverSheet/univer/univer-sheet.bundle.css');
}
export async function createUniverSheetAsync(sheet) {
sheet.lang = sheet.lang ?? 'en-US';
await loadAssets();

Copilot uses AI. Check for mistakes.
Expand Down
18 changes: 18 additions & 0 deletions src/components/BootstrapBlazor.UniverSheet/wwwroot/univer/univer-bundle.css
View file
Open in desktop

Large diffs are not rendered by default.

Loading