Skip to content

refactor(PdfReader): add z-index value#825

Merged
ArgoZhang merged 2 commits intomasterfrom
refactor-pdf
Dec 14, 2025
Merged

refactor(PdfReader): add z-index value#825
ArgoZhang merged 2 commits intomasterfrom
refactor-pdf

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 14, 2025

Link issues

fixes #824

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Set an explicit z-index on the PdfReader view progress bar to improve its visual stacking order relative to other UI elements.

Copilot AI review requested due to automatic review settings December 14, 2025 06:28
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 14, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Dec 14, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Dec 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a z-index to the PDF reader's top progress bar to ensure it renders above overlapping content; no functional changes are made to the project file.

File-Level Changes

Change Details Files
Ensure the PDF reader's top progress bar visually overlays other content by adjusting its stacking order.
  • Set a z-index value on the top progress bar element to control stacking context when overlapping other UI elements
  • Retain existing positioning and sizing styles for the progress bar without modification
src/components/BootstrapBlazor.PdfReader/wwwroot/css/pdf_reader.css

Assessment against linked issues

Issue Objective Addressed Explanation
#824 Add a z-index value to the relevant PdfReader component styles to resolve layering/stacking issues.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit ff8463f into master Dec 14, 2025
3 of 4 checks passed
@ArgoZhang ArgoZhang deleted the refactor-pdf branch December 14, 2025 06:28
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider documenting why z-index: 10 was chosen or aligning it with any existing z-index scale/tokens in the project to avoid future stacking conflicts.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider documenting why `z-index: 10` was chosen or aligning it with any existing z-index scale/tokens in the project to avoid future stacking conflicts.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a z-index layering issue in the PdfReader component by ensuring the progress bar appears above other UI elements. The change addresses issue #824 with a simple CSS addition and corresponding version bump.

Key Changes:

  • Added z-index: 10 to the .bb-view-progress CSS class to fix layering issues
  • Bumped component version from 10.0.16 to 10.0.17

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/BootstrapBlazor.PdfReader/wwwroot/css/pdf_reader.css Added z-index property to progress bar to ensure it displays above other content
src/components/BootstrapBlazor.PdfReader/BootstrapBlazor.PdfReader.csproj Incremented patch version to reflect the CSS fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(PdfReader): add z-index value

2 participants