Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR removes the IHikVision interface abstraction layer that was previously used for dependency injection. The functionality has been consolidated into the HikVisionWebPlugin component, which provides all the same methods (Login, Logout, StartRealPlay, StopRealPlay) directly. This simplifies the API by eliminating the need for service registration and favoring direct component usage.
Key changes:
- Removed
IHikVisioninterface and itsDefaultHicVisionimplementation - Removed
AddBootstrapBlazorHikVisionservice collection extension - Bumped package version from 10.0.3 to 10.0.4
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Services/IHikVision.cs |
Deleted the interface that defined HikVision camera operations |
Services/DefaultHicVision.cs |
Deleted the default implementation that was registered via DI |
Extensions/ServiceCollectionExtensions.cs |
Deleted the DI registration extension method |
BootstrapBlazor.HikVision.csproj |
Bumped version to 10.0.4 to reflect the API change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #806
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the HikVision service interface and its default implementation from the component library.
Enhancements:
Build: