Skip to content

chore(HikVision): remove IHikVision interface#807

Merged
ArgoZhang merged 2 commits intomasterfrom
chore-hik
Dec 10, 2025
Merged

chore(HikVision): remove IHikVision interface#807
ArgoZhang merged 2 commits intomasterfrom
chore-hik

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 10, 2025

Link issues

fixes #806

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Remove the HikVision service interface and its default implementation from the component library.

Enhancements:

  • Delete the IHikVision interface and its DefaultHicVision implementation along with related service registration extensions from the HikVision component package.

Build:

  • Update the HikVision project file to reflect removal of the HikVision service abstractions and related classes.

Copilot AI review requested due to automatic review settings December 10, 2025 02:10
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 10, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Dec 10, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone Dec 10, 2025
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit ba5986d into master Dec 10, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the chore-hik branch December 10, 2025 02:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the IHikVision interface abstraction layer that was previously used for dependency injection. The functionality has been consolidated into the HikVisionWebPlugin component, which provides all the same methods (Login, Logout, StartRealPlay, StopRealPlay) directly. This simplifies the API by eliminating the need for service registration and favoring direct component usage.

Key changes:

  • Removed IHikVision interface and its DefaultHicVision implementation
  • Removed AddBootstrapBlazorHikVision service collection extension
  • Bumped package version from 10.0.3 to 10.0.4

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Services/IHikVision.cs Deleted the interface that defined HikVision camera operations
Services/DefaultHicVision.cs Deleted the default implementation that was registered via DI
Extensions/ServiceCollectionExtensions.cs Deleted the DI registration extension method
BootstrapBlazor.HikVision.csproj Bumped version to 10.0.4 to reflect the API change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(HikVision): remove IHikVision interface

2 participants