Skip to content

feat(HikVision): add instance method #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 1 commit into from
Dec 4, 2025
Merged

feat(HikVision): add instance method #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/components/BootstrapBlazor.HikVision/Components/HikVision.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ protected override void OnParametersSet()
/// <param name="password"></param>
/// <param name="loginType"></param>
/// <returns></returns>
public async Task Login(string ip, string port, string userName, string password, LoginType loginType = LoginType.Http)
public async Task Login(string ip, int port, string userName, string password, LoginType loginType = LoginType.Http)
{
await InvokeVoidAsync("login", Id, ip, port, userName, password, (int)loginType);
}
Expand All @@ -97,4 +97,22 @@ public async Task Logout()
{
await InvokeVoidAsync("logout", Id);
}

/// <summary>
/// 开始实时预览方法
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation comment differs slightly from the interface definition. The interface (IHikVision) uses "开始实时预览画面方法" (Start real-time preview screen method) on line 32, while this implementation uses "开始实时预览方法" (Start real-time preview method). Consider using the same wording as the interface for consistency: "开始实时预览画面方法".

Suggested change
/// 开始实时预览方法
/// 开始实时预览画面方法

Copilot uses AI. Check for mistakes.
/// </summary>
/// <returns></returns>
public async Task StartRealPlay()
{
await InvokeVoidAsync("startRealPlay", Id);
}

/// <summary>
/// 停止实时预览方法
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation comment differs slightly from the interface definition. The interface (IHikVision) uses "停止实时预览画面方法" (Stop real-time preview screen method) on line 38, while this implementation uses "停止实时预览方法" (Stop real-time preview method). Consider using the same wording as the interface for consistency: "停止实时预览画面方法".

Suggested change
/// 停止实时预览方法
/// 停止实时预览画面方法

Copilot uses AI. Check for mistakes.
/// </summary>
/// <returns></returns>
public async Task StopRealPlay()
{
await InvokeVoidAsync("stopRealPlay", Id);
}
}
Loading