Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects a version mismatch in the UniverSheet component project file. The version is being rolled back from 10.0.1 to 9.0.6, and the BootstrapBlazor package reference is changed from a variable reference to a hardcoded version 9.0.0.
- Version rollback from 10.0.1 to 9.0.6
- BootstrapBlazor package reference changed from variable
$(BBVersion)to hardcoded "9.0.0"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" /> | ||
| <PackageReference Include="BootstrapBlazor" Version="9.0.0" /> |
There was a problem hiding this comment.
Hardcoding the BootstrapBlazor version removes the benefit of centralized version management via $(BBVersion). This makes it harder to maintain consistency across multiple projects and requires manual updates in each location when the version changes. Consider keeping the variable reference or documenting why this specific component requires a hardcoded version.
| <PackageReference Include="BootstrapBlazor" Version="9.0.0" /> | |
| <PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" /> |
Link issues
fixes #763
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Build: