Skip to content

fix(UniverSheet): plug path incorrect#764

Merged
ArgoZhang merged 1 commit intomasterfrom
dev-univer-sheet
Dec 1, 2025
Merged

fix(UniverSheet): plug path incorrect#764
ArgoZhang merged 1 commit intomasterfrom
dev-univer-sheet

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 1, 2025

Link issues

fixes #763

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Build:

  • Update BootstrapBlazor.UniverSheet project file to point to the correct plug path for the UniverSheet component.

Copilot AI review requested due to automatic review settings December 1, 2025 08:23
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 1, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Dec 1, 2025
@ArgoZhang ArgoZhang merged commit 8e3fc74 into master Dec 1, 2025
3 of 4 checks passed
@ArgoZhang ArgoZhang deleted the dev-univer-sheet branch December 1, 2025 08:23
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a version mismatch in the UniverSheet component project file. The version is being rolled back from 10.0.1 to 9.0.6, and the BootstrapBlazor package reference is changed from a variable reference to a hardcoded version 9.0.0.

  • Version rollback from 10.0.1 to 9.0.6
  • BootstrapBlazor package reference changed from variable $(BBVersion) to hardcoded "9.0.0"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


<ItemGroup>
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />
<PackageReference Include="BootstrapBlazor" Version="9.0.0" />
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the BootstrapBlazor version removes the benefit of centralized version management via $(BBVersion). This makes it harder to maintain consistency across multiple projects and requires manual updates in each location when the version changes. Consider keeping the variable reference or documenting why this specific component requires a hardcoded version.

Suggested change
<PackageReference Include="BootstrapBlazor" Version="9.0.0" />
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(UniverSheet): plug path incorrect

2 participants