Skip to content

chore(PdfReader): bump version 10.0.2#735

Merged
ArgoZhang merged 2 commits intomasterfrom
fix-scale
Nov 27, 2025
Merged

chore(PdfReader): bump version 10.0.2#735
ArgoZhang merged 2 commits intomasterfrom
fix-scale

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Nov 27, 2025

Link issues

fixes #734

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Align PdfReader scale control wiring with updated DOM structure and version metadata.

Bug Fixes:

  • Fix PdfReader JavaScript to target the correct scale input element for page zoom changes.

Build:

  • Update PdfReader project metadata to the new version.

Copilot AI review requested due to automatic review settings November 27, 2025 07:39
@bb-auto bb-auto Bot added the chore label Nov 27, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Nov 27, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 27, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

PdfReader viewer control wiring is updated to reference the correct scale input element CSS class and the component package version is bumped to 10.0.2.

Sequence diagram for PdfReader scalechanging handling

sequenceDiagram
    actor User
    participant PdfReaderElement as PdfReaderElement
    participant ZoomControls as ZoomControls
    participant PdfViewer as PdfViewer
    participant EventBus as EventBus
    participant JsHandler as PdfReaderJs

    User->>PdfReaderElement: Click bb-page-plus or bb-page-minus
    PdfReaderElement->>ZoomControls: Trigger zoom control handler
    ZoomControls->>PdfViewer: Request zoom change
    PdfViewer-->>EventBus: Emit scalechanging(scale)
    EventBus-->>JsHandler: scalechanging event
    JsHandler->>PdfReaderElement: querySelector(.bb-view-scale-input)
    JsHandler->>ZoomControls: Update scale input value
    JsHandler->>ZoomControls: Update other zoom UI state
Loading

File-Level Changes

Change Details Files
Fix scale control wiring by targeting the specific scale input element in the PdfReader toolbar.
  • Change the DOM query selector used for the viewer scale element from a generic scale class to the more specific scale input class.
  • Ensure scale change events update the correct input element when zoom level changes.
src/components/BootstrapBlazor.PdfReader/PdfReader.razor.js
Update PdfReader component package metadata to version 10.0.2.
  • Bump the project/package version number to 10.0.2 in the PdfReader project file to reflect the latest release.
src/components/BootstrapBlazor.PdfReader/BootstrapBlazor.PdfReader.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#734 Update the BootstrapBlazor.PdfReader component/package version to 10.0.2.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 68e0041 into master Nov 27, 2025
3 of 4 checks passed
@ArgoZhang ArgoZhang deleted the fix-scale branch November 27, 2025 07:39
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider keeping backward compatibility by querying both the new .bb-view-scale-input and the previous .bb-view-scale class (fallback if the new one is not found) to avoid breaking existing markup.
  • It may be safer to guard against scaleEl being null before using it in the event handlers, so a missing or misnamed element doesn’t cause runtime errors.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider keeping backward compatibility by querying both the new `.bb-view-scale-input` and the previous `.bb-view-scale` class (fallback if the new one is not found) to avoid breaking existing markup.
- It may be safer to guard against `scaleEl` being `null` before using it in the event handlers, so a missing or misnamed element doesn’t cause runtime errors.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the PdfReader component where the JavaScript code was incorrectly querying for a container div (.bb-view-scale) instead of the actual input element (.bb-view-scale-input) that displays the zoom scale percentage. The patch version is bumped from 10.0.1 to 10.0.2 to reflect this bug fix.

Key changes:

  • Corrected JavaScript selector to target the scale input element instead of its parent container
  • Bumped version to 10.0.2 following semantic versioning for a bug fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
PdfReader.razor.js Fixed selector to query .bb-view-scale-input (the input element) instead of .bb-view-scale (the container div), ensuring the scale value is correctly set on the input element
BootstrapBlazor.PdfReader.csproj Bumped version from 10.0.1 to 10.0.2 for this bug fix release
Comments suppressed due to low confidence (1)

src/components/BootstrapBlazor.PdfReader/PdfReader.razor.js:247

  • The initial value of v is unused, since it is always overwritten.
    let v = 100;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(PdfReader): bump version 10.0.2

2 participants