-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(PdfReader): add ShowPrint parameter #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
16fe32a
refactor: 使用原生下拉框
ArgoZhang 2fa21f7
feat: 增加 FitMode 功能
ArgoZhang ddef937
doc: 更新文档
ArgoZhang 8471023
refactor: 移除不使用的代码
ArgoZhang 1322fff
feat: 增加是否打印控制功能
ArgoZhang af420db
chore: bump version10.0.1-beta07
ArgoZhang ac27898
chore: 更新依赖
ArgoZhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,6 +25,12 @@ public partial class PdfReader | |||||
| [Parameter] | ||||||
| public bool ShowDownload { get; set; } = true; | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// 获得/设置 是否显示打印按钮 默认 true 显示 | ||||||
| /// </summary> | ||||||
| [Parameter] | ||||||
| public bool ShowPrint { get; set; } = true; | ||||||
|
|
||||||
| /// <summary> | ||||||
| /// 获得/设置 是否显示缩略图 默认 true 显示 | ||||||
| /// </summary> | ||||||
|
|
@@ -59,13 +65,13 @@ public partial class PdfReader | |||||
| /// 获得/设置 是否适配当前页面宽度 默认 false | ||||||
|
||||||
| /// 获得/设置 是否适配当前页面宽度 默认 false | |
| /// 获得/设置 文档适配模式 默认 Auto |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FitMode enum value is being passed directly to JavaScript, but it needs to be converted to its description string value (e.g., "page-width", "page-height"). It should be FitMode.ToDescriptionString() or a similar conversion, similar to what's done on line 232.
Suggested change
| FitMode, | |
| FitMode = FitMode.ToDescriptionString(), |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation comment "适应页面宽度" (Fit to page width) is misleading. This method now sets any fit mode via parameter, not just page width. The comment should be updated to reflect the actual functionality, e.g., "设置文档适配模式" (Set document fit mode).
Suggested change
| /// 适应页面宽度 | |
| /// 设置文档适配模式 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -51,17 +51,10 @@ export async function init(id, invoke, options) { | |||||
| Data.set(id, { el, pdfViewer }); | ||||||
| } | ||||||
|
|
||||||
| export function fitToWidth(id) { | ||||||
| export function setScaleValue(id, value) { | ||||||
| const { pdfViewer } = Data.get(id); | ||||||
| if (pdfViewer) { | ||||||
| pdfViewer.currentScaleValue = "page-height"; | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| export function fitToPage(id) { | ||||||
| const { pdfViewer } = Data.get(id); | ||||||
| if (pdfViewer) { | ||||||
| pdfViewer.currentScaleValue = "page-width"; | ||||||
| pdfViewer.currentScaleValue = value; | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -118,11 +111,8 @@ const resetTwoPagesOneView = (el, pdfViewer) => { | |||||
|
|
||||||
| const addEventListener = (el, pdfViewer, eventBus, invoke, options) => { | ||||||
| eventBus.on("pagesinit", async () => { | ||||||
| if (options.isFitToPage) { | ||||||
| pdfViewer.currentScaleValue = "page-width"; | ||||||
| } | ||||||
| else { | ||||||
| pdfViewer.currentScaleValue = "page-actual"; | ||||||
| if (options.fitMode) { | ||||||
| pdfViewer.currentScaleValue = fitMode; | ||||||
|
||||||
| pdfViewer.currentScaleValue = fitMode; | |
| pdfViewer.currentScaleValue = options.fitMode; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dropdown items display raw technical values (e.g., "page-actual", "page-width") which are not user-friendly. Consider using localized or human-readable labels instead, similar to how the enum descriptions are used in Chinese comments (e.g., "实际大小" for PageActual, "页面宽度" for PageWidth).