Skip to content

chore(Encoding): use utf-8 encoding#691

Merged
ArgoZhang merged 1 commit intomasterfrom
chore-config
Nov 13, 2025
Merged

chore(Encoding): use utf-8 encoding#691
ArgoZhang merged 1 commit intomasterfrom
chore-config

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Nov 13, 2025

Link issues

fixes #690

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enforce UTF-8 encoding across the project by updating the .editorconfig settings.

Bug Fixes:

Chores:

  • Update .editorconfig to enforce UTF-8 charset for all files

Copilot AI review requested due to automatic review settings November 13, 2025 00:43
@bb-auto bb-auto Bot added the chore label Nov 13, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Nov 13, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 13, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 8979778 into master Nov 13, 2025
4 of 6 checks passed
@ArgoZhang ArgoZhang deleted the chore-config branch November 13, 2025 00:44
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to enforce UTF-8 encoding for .csproj files by adding a specific section in the .editorconfig file. However, this change is redundant as the charset is already configured globally and .csproj files are already covered by an existing pattern.

  • Added a [*.csproj] section with charset = utf-8 to .editorconfig

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .editorconfig
Comment on lines +91 to +93
[*.csproj]
charset = utf-8

Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is redundant. The charset is already set to utf-8 globally for all files on line 11, and *.csproj files are already covered by the [*.{xml,config,*proj,nuspec,props,resx,targets,yml,tasks}] section on line 74. This additional section doesn't provide any new configuration and can be removed.

Suggested change
[*.csproj]
charset = utf-8

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Encoding): use utf-8 encoding

2 participants