chore(BaiduSpeech): bump Newtonsoft.Json version to latest#679
chore(BaiduSpeech): bump Newtonsoft.Json version to latest#679
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds an explicit Newtonsoft.Json package reference to the BaiduSpeech component to resolve issue #678, likely addressing a missing or outdated transitive dependency.
- Adds Newtonsoft.Json v13.* as a direct dependency to BootstrapBlazor.BaiduSpeech
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ItemGroup> | ||
| <PackageReference Include="Baidu.AI" Version="4.15.16" /> | ||
| <PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.*" /> |
There was a problem hiding this comment.
The wildcard version pattern 13.* is inconsistent with other components in the project. Other components like BootstrapBlazor.OCR and BootstrapBlazor.OpenAI.GPT3 use the specific version 13.0.3 for Newtonsoft.Json. Consider using a specific version (e.g., 13.0.3) instead of a wildcard pattern to ensure consistent dependencies across the project and avoid unexpected breaking changes from minor/patch version updates.
| <PackageReference Include="Newtonsoft.Json" Version="13.*" /> | |
| <PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> |
Link issues
fixes #678
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Upgrade Newtonsoft.Json dependency in BaiduSpeech component to the latest version, resolving issue #678.
Bug Fixes:
Build: