Conversation
Reviewer's GuideThis PR reorganizes the CssBundler CLI tool by moving it to a top-level tools directory, updates internal usage messages to match the new location, refines JSON deserialization defaults, and adds accompanying documentation files. Class diagram for BundlerOptions changesclassDiagram
class BundlerOptions {
+static List~BundlerOptions~ LoadFromConfigFile(string configFile)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The change from
new()to[]in LoadFromConfigFile is not valid C# for instantiating a List; please revert to something likenew List<BundlerOptions>(). - The new README under tools/CssBundler duplicates the main project documentation; consider trimming it down or moving it to the root README to avoid divergence.
- The CLI usage examples use hard-coded Windows paths—consider switching to relative paths or more generic examples for cross-platform users.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change from `new()` to `[]` in LoadFromConfigFile is not valid C# for instantiating a List; please revert to something like `new List<BundlerOptions>()`.
- The new README under tools/CssBundler duplicates the main project documentation; consider trimming it down or moving it to the root README to avoid divergence.
- The CLI usage examples use hard-coded Windows paths—consider switching to relative paths or more generic examples for cross-platform users.
## Individual Comments
### Comment 1
<location> `tools/BootstrapBlazor.CssBundler/readme.md:29` </location>
<code_context>
+## Installation Guide
+
+- Install .net core sdk [Official website](https://dotnet.microsoft.com/download)
+- Install Visual Studio 2019 lastest [Official website](https://visualstudio.microsoft.com/vs/getting-started/)
+
+```shell
</code_context>
<issue_to_address>
**issue (typo):** Typo: 'lastest' should be 'latest'.
Update the installation instructions to use 'latest' instead of 'lastest'.
```suggestion
- Install Visual Studio 2019 latest [Official website](https://visualstudio.microsoft.com/vs/getting-started/)
```
</issue_to_address>
### Comment 2
<location> `tools/BootstrapBlazor.CssBundler/readme.md:61` </location>
<code_context>
+
+`dotnet add package BootstrapBlazor`
+
+2. **Add** the `stylesheet` `javascripts` file to your main index file - `Pages/_Host.cshtml (Server)` or `wwwroot/index.html (WebAssembly)`
+
+ **HTML**
</code_context>
<issue_to_address>
**issue (typo):** Typo: 'javascripts' should be 'JavaScript files'.
Please update the wording to 'JavaScript files' for improved clarity.
```suggestion
2. **Add** the `stylesheet` and `JavaScript files` to your main index file - `Pages/_Host.cshtml (Server)` or `wwwroot/index.html (WebAssembly)`
```
</issue_to_address>
### Comment 3
<location> `tools/BootstrapBlazor.CssBundler/readme.md:80` </location>
<code_context>
+</html>
+```
+
+3. Open the `~/Startup.cs` file in the and register the `Bootstrap Blazor` service:
+
+ **C#**
</code_context>
<issue_to_address>
**issue (typo):** Awkward phrasing: 'in the and register' should be corrected.
Change the sentence to: 'Open the `~/Startup.cs` file and register the `Bootstrap Blazor` service:'.
```suggestion
3. Open the `~/Startup.cs` file and register the `Bootstrap Blazor` service:
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ## Installation Guide | ||
|
|
||
| - Install .net core sdk [Official website](https://dotnet.microsoft.com/download) | ||
| - Install Visual Studio 2019 lastest [Official website](https://visualstudio.microsoft.com/vs/getting-started/) |
There was a problem hiding this comment.
issue (typo): Typo: 'lastest' should be 'latest'.
Update the installation instructions to use 'latest' instead of 'lastest'.
Suggested change
| - Install Visual Studio 2019 lastest [Official website](https://visualstudio.microsoft.com/vs/getting-started/) | |
| - Install Visual Studio 2019 latest [Official website](https://visualstudio.microsoft.com/vs/getting-started/) |
|
|
||
| `dotnet add package BootstrapBlazor` | ||
|
|
||
| 2. **Add** the `stylesheet` `javascripts` file to your main index file - `Pages/_Host.cshtml (Server)` or `wwwroot/index.html (WebAssembly)` |
There was a problem hiding this comment.
issue (typo): Typo: 'javascripts' should be 'JavaScript files'.
Please update the wording to 'JavaScript files' for improved clarity.
Suggested change
| 2. **Add** the `stylesheet` `javascripts` file to your main index file - `Pages/_Host.cshtml (Server)` or `wwwroot/index.html (WebAssembly)` | |
| 2. **Add** the `stylesheet` and `JavaScript files` to your main index file - `Pages/_Host.cshtml (Server)` or `wwwroot/index.html (WebAssembly)` |
| </html> | ||
| ``` | ||
|
|
||
| 3. Open the `~/Startup.cs` file in the and register the `Bootstrap Blazor` service: |
There was a problem hiding this comment.
issue (typo): Awkward phrasing: 'in the and register' should be corrected.
Change the sentence to: 'Open the ~/Startup.cs file and register the Bootstrap Blazor service:'.
Suggested change
| 3. Open the `~/Startup.cs` file in the and register the `Bootstrap Blazor` service: | |
| 3. Open the `~/Startup.cs` file and register the `Bootstrap Blazor` service: |
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes and refactors the BootstrapBlazor.CssBundler tool by moving it from src/tools/ to tools/ directory and updating its implementation. The main changes include updating the version to 9.0.0, modernizing C# syntax with collection expressions, cleaning up the project structure, and adding documentation files.
- Relocated the CssBundler project from
src/tools/totools/directory - Updated version from 1.0.1 to 9.0.0 and modernized code syntax (collection expressions)
- Added readme.md and logo.png files for documentation
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/BootstrapBlazor.CssBundler/readme.md | Added comprehensive documentation for the BootstrapBlazor component library |
| tools/BootstrapBlazor.CssBundler/logo.png | Added binary logo image file |
| tools/BootstrapBlazor.CssBundler/Program.cs | New entry point file for the bundler tool |
| tools/BootstrapBlazor.CssBundler/BundlerOptions.cs | Updated to use collection expression syntax ([] instead of new()) |
| tools/BootstrapBlazor.CssBundler/Bundler.cs | New file containing the core bundler logic |
| tools/BootstrapBlazor.CssBundler/BootstrapBlazor.CssBundler.xml | Added XML documentation file |
| tools/BootstrapBlazor.CssBundler/BootstrapBlazor.CssBundler.csproj | Updated version to 9.0.0 and reorganized properties |
| tools/BootstrapBlazor.CssBundler/ArgumentsHelper.cs | Updated usage text and example paths |
| BootstrapBlazor.Extensions.slnx | Updated solution structure to reflect new tools directory location |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Installation Guide | ||
|
|
||
| - Install .net core sdk [Official website](https://dotnet.microsoft.com/download) | ||
| - Install Visual Studio 2019 lastest [Official website](https://visualstudio.microsoft.com/vs/getting-started/) |
There was a problem hiding this comment.
Corrected spelling of 'lastest' to 'latest'.
Suggested change
| - Install Visual Studio 2019 lastest [Official website](https://visualstudio.microsoft.com/vs/getting-started/) | |
| - Install Visual Studio 2019 latest [Official website](https://visualstudio.microsoft.com/vs/getting-started/) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #666
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Move the CSS bundler CLI tool to a root-level tools directory, update solution and project references, refine help messaging and deserialization behavior, and add documentation files
Enhancements:
Documentation:
Chores: