feat(Markdown): support ShowLabel parameter#657
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideImplements a ShowLabel parameter in the Markdown component to control label rendering and refactors the Update method’s parameter naming for clarity. Sequence diagram for Update method parameter change in Markdown componentsequenceDiagram
participant JS as "JavaScript"
participant Markdown
JS->>Markdown: Update([value, html])
Markdown->>Markdown: Set CurrentValueAsString = value
Markdown->>Markdown: Compare html with Html
alt Html has changed
Markdown->>Markdown: Set Html = html
Markdown->>Markdown: Invoke HtmlChanged(Html)
end
Class diagram for updated Markdown component with ShowLabel parameterclassDiagram
class Markdown {
+bool IsShowLabel
+bool ShowLabelTooltip
+string DisplayText
+bool Required
+string Id
+string Html
+EventCallback<string> HtmlChanged
+Task Update(string[] values)
}
class ValidateBase_string {
}
Markdown --|> ValidateBase_string
class BootstrapLabel {
+bool required
+string for
+bool ShowLabelTooltip
+string Value
}
Markdown "1" o-- "0..1" BootstrapLabel : renders if IsShowLabel
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds label support to the Markdown component and improves code quality through parameter renaming. The changes align the Markdown component with other similar editor components in the codebase that already support labels.
- Added label rendering support using the
IsShowLabelproperty fromValidateBase - Improved parameter naming in the
Updatemethod fromvalstovalues - Incremented package version to 9.0.3
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/BootstrapBlazor.Markdown/Components/Markdown/Markdown.razor | Added BootstrapLabel component rendering when IsShowLabel is true, consistent with other editor components |
| src/components/BootstrapBlazor.Markdown/Components/Markdown/Markdown.razor.cs | Renamed parameter from vals to values for better clarity and removed BOM character |
| src/components/BootstrapBlazor.Markdown/BootstrapBlazor.Markdown.csproj | Updated package version from 9.0.2 to 9.0.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #656
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Support an optional label in the Markdown component and refactor the Update method parameter name
New Features:
Enhancements: