feat(CherryMarkdown): auto show label in validate form#651
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors CherryMarkdown to integrate with the form validation framework by inheriting from ValidateBase and automatically rendering its label when used inside a validation form. Updated class diagram for CherryMarkdown integration with ValidateBaseclassDiagram
class CherryMarkdown {
+bool IsSupportMath
+string? _lastValue
+string? Html
+bool IsShowLabel
+bool Required
+string? Id
+string? DisplayText
+bool ShowLabelTooltip
+IDictionary<string, object>? AdditionalAttributes
// Inherits Value, ValueChanged, etc. from ValidateBase<string>
}
class ValidateBase~T~ {
+T Value
+EventCallback<T> ValueChanged
+bool IsShowLabel
+bool Required
+string? Id
+string? DisplayText
+bool ShowLabelTooltip
+IDictionary<string, object>? AdditionalAttributes
}
CherryMarkdown --|> ValidateBase~string~
Flow diagram for CherryMarkdown label rendering in validation formsflowchart TD
A[CherryMarkdown used in validation form] --> B{IsShowLabel}
B -- Yes --> C[Render BootstrapLabel with required, for, tooltip, and value]
B -- No --> D[Do not render label]
C --> E[Render markdown editor]
D --> E[Render markdown editor]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CherryMarkdown component to inherit from ValidateBase<string> instead of BootstrapModuleComponentBase, enabling form validation capabilities and consistent label rendering.
- Changed base class from
BootstrapModuleComponentBasetoValidateBase<string> - Added label rendering support using
IsShowLabel,Required,ShowLabelTooltip, andDisplayTextproperties - Removed redundant
ValueandValueChangedproperty declarations (now inherited fromValidateBase<string>)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CherryMarkdown.razor | Changed inheritance to ValidateBase<string> and added conditional label rendering |
| CherryMarkdown.razor.cs | Removed Value and ValueChanged properties that are now inherited from base class, fixed leading whitespace |
| BootstrapBlazor.CherryMarkdown.csproj | Bumped version from 9.0.3 to 9.0.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #650
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Integrate CherryMarkdown with the validation framework to automatically render its label in forms and simplify its parameter model.
New Features:
Enhancements: