-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(OctIcon): bump version 9.0.7 #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,16 +1,24 @@ | ||||||
| <Project Sdk="Microsoft.NET.Sdk.Razor"> | ||||||
|
|
||||||
| <PropertyGroup> | ||||||
| <Version>9.0.6</Version> | ||||||
| <PropertyGroup Condition="'$(VisualStudioVersion)' == '17.0'"> | ||||||
| <Version>9.0.7</Version> | ||||||
| </PropertyGroup> | ||||||
|
|
||||||
| <PropertyGroup Condition="'$(VisualStudioVersion)' == '18.0'"> | ||||||
| <Version>10.0.0-rc.2.1.0</Version> | ||||||
| </PropertyGroup> | ||||||
|
|
||||||
| <PropertyGroup> | ||||||
| <PackageTags>Bootstrap Blazor WebAssembly wasm UI Components Icon</PackageTags> | ||||||
| <Description>Bootstrap UI components extensions of OctIcon</Description> | ||||||
| </PropertyGroup> | ||||||
|
|
||||||
| <ItemGroup> | ||||||
| <ItemGroup Condition="'$(VisualStudioVersion)' == '17.0'"> | ||||||
| <PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" /> | ||||||
|
||||||
| <PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" /> | |
| <PackageReference Include="BootstrapBlazor" Version="9.12.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The conditional versioning approach based on
VisualStudioVersionproperty is inconsistent with the BootstrapBlazor.Topology.csproj file in the same repository, which uses a single unconditional ItemGroup for the BootstrapBlazor package reference. Consider whether this conditional approach is necessary for this specific component or if it should follow the simpler pattern used in Topology.