Skip to content

feat(Drivejs): remove AutoDrive parameter #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 2 commits into from
Oct 31, 2025
Merged

feat(Drivejs): remove AutoDrive parameter #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf77a5
refactor: 移除 AutoDrive 参数
ArgoZhang Oct 31, 2025
712b875
chore: bump version 9.0.5
ArgoZhang Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/components/BootstrapBlazor.DriverJs/BootstrapBlazor.DriverJs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup Condition="'$(VisualStudioVersion)' == '17.0'">
<Version>9.0.5</Version>
</PropertyGroup>

<PropertyGroup Condition="'$(VisualStudioVersion)' == '18.0'">
<Version>10.0.0-rc.2.1.0</Version>
</PropertyGroup>

<PropertyGroup>
<Version>9.0.3</Version>
<RootNamespace>BootstrapBlazor.Components</RootNamespace>
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Version property has been removed from the unconditional <PropertyGroup> and only defined conditionally. If VisualStudioVersion is not '17.0' or '18.0', no version will be set, which could cause build issues. Consider adding a fallback version in the unconditional PropertyGroup or handle other VisualStudioVersion values.

Suggested change
<RootNamespace>BootstrapBlazor.Components</RootNamespace>
<RootNamespace>BootstrapBlazor.Components</RootNamespace>
<Version>10.0.0-rc.2.1.0</Version>

Copilot uses AI. Check for mistakes.
</PropertyGroup>

Expand All @@ -15,10 +22,14 @@
<EmbeddedResource Include="Locales\*.json" />
</ItemGroup>

<ItemGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '17.0'">
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BootstrapBlazor package reference for Visual Studio 17.0 uses a variable $(BBVersion), while the Visual Studio 18.0 version uses a hardcoded value. This inconsistency makes maintenance harder. Consider either using $(BBVersion) for both versions or hardcoding both for consistency.

Suggested change
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />
<PackageReference Include="BootstrapBlazor" Version="10.0.0-rc.2.1.0" />

Copilot uses AI. Check for mistakes.
</ItemGroup>

<ItemGroup Condition="'$(VisualStudioVersion)' == '18.0'">
<PackageReference Include="BootstrapBlazor" Version="10.0.0-rc.2.1.0" />
</ItemGroup>

<ItemGroup>
<Using Include="Microsoft.AspNetCore.Components" />
<Using Include="Microsoft.Extensions.Localization" />
Expand Down
3 changes: 2 additions & 1 deletion src/components/BootstrapBlazor.DriverJs/Components/DriverJs.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ public partial class DriverJs
/// 获得/设置 是否自动开始向导 默认 true
/// </summary>
[Parameter]
[Obsolete("已弃用，删除即可；Deprecated, just delete it")]
[ExcludeFromCodeCoverage]
public bool AutoDrive { get; set; } = true;

/// <summary>
Expand Down Expand Up @@ -53,7 +55,6 @@ public async Task Start(int? index = 0)

await InvokeVoidAsync("start", Id, Config, new
{
AutoDrive,
Index = index
});
}
Expand Down
7 changes: 2 additions & 5 deletions src/components/BootstrapBlazor.DriverJs/Components/DriverJs.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function start(id, options, config) {
const d = Data.get(id);
if (d) {
d.config = config;
const { autoDrive, index } = config;
const { index } = config;
const { hookDestroyStarted, hookDestroyed } = options;
if (hookDestroyStarted) {
delete options.hookDestroyStarted;
Expand All @@ -36,10 +36,7 @@ export function start(id, options, config) {
}
const driverObj = driver(options);
d.driver = driverObj;

if (autoDrive) {
driverObj.drive(index);
}
driverObj.drive(index);
}
}

Expand Down
Loading