Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Topology component by removing conditional compilation so the EditorRequired attribute is always applied to the Content parameter, and bumps the package version to 9.0.2. Class diagram for updated Topology component parameter attributesclassDiagram
class Topology {
+string Content
}
Topology : [EditorRequired]
Topology : [Parameter]
Topology : [NotNull]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version of the BootstrapBlazor.Topology component to 9.0.2 and removes the conditional compilation directive for the EditorRequired attribute, making it available across all supported .NET versions.
- Removed
#if NET6_0_OR_GREATERconditional compilation directive from theEditorRequiredattribute - Updated version scheme to support Visual Studio version-specific builds (9.0.2 for VS 17.0, 10.0.0-rc.2.1.0 for VS 18.0)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Topology.razor.cs | Removed conditional compilation directive around EditorRequired attribute to make it unconditionally available |
| BootstrapBlazor.Topology.csproj | Updated versioning strategy to use Visual Studio version-specific property groups |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #627
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bump Topology package to version 9.0.2 and remove conditional compilation around the Content parameter’s EditorRequired attribute
Bug Fixes:
Enhancements:
Build: