Skip to content

fix(SelectCity): reset Value after update IsMultiple parameter #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 2 commits into from
Oct 18, 2025
Merged

fix(SelectCity): reset Value after update IsMultiple parameter #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9355f22
fix: 修复切换 IsMultiple 参数时值未清空问题
ArgoZhang Oct 18, 2025
5352b13
chore: bump version 9.0.6
ArgoZhang Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/BootstrapBlazor.Region/BootstrapBlazor.Region.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.0.5</Version>
<Version>9.0.6</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
8 changes: 7 additions & 1 deletion src/components/BootstrapBlazor.Region/Components/SelectCity.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ public partial class SelectCity
private string? _searchText;

private string? GetActiveClass(string item) => CssBuilder.Default()
.AddClass("active", _values.Contains(item) || CurrentValue == item)
.AddClass("active", _values.Contains(item) && IsMultiple)
.AddClass("active", CurrentValue == item && !IsMultiple)
Comment on lines +56 to +57
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two separate AddClass calls for the same CSS class 'active' could be combined into a single call with a more readable condition. Consider: .AddClass('active', (IsMultiple && _values.Contains(item)) || (!IsMultiple && CurrentValue == item))

Suggested change
.AddClass("active", _values.Contains(item) && IsMultiple)
.AddClass("active", CurrentValue == item && !IsMultiple)
.AddClass("active", (IsMultiple && _values.Contains(item)) || (!IsMultiple && CurrentValue == item))

Copilot uses AI. Check for mistakes.
.AddClass("prev", !string.IsNullOrEmpty(_searchText) && PinYinService.GetFirstLetters(item).StartsWith(_searchText))
.Build();

Expand All @@ -65,6 +66,11 @@ protected override void OnParametersSet()
base.OnParametersSet();

SearchIcon ??= IconTheme.GetIconByKey(ComponentIcons.SelectSearchIcon);

if (!IsMultiple)
{
_values.Clear();
Comment on lines +70 to +72
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Clearing _values on every parameter set may unintentionally remove user selections.

Clearing _values each time may erase user selections if OnParametersSet runs multiple times. Consider restricting this to cases where IsMultiple transitions from true to false.

}
}

/// <summary>
Expand Down