Skip to content

feat(Region): support dark theme #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 3 commits into from
Oct 16, 2025
Merged

feat(Region): support dark theme #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e44d0f
refactor: 更新样式
ArgoZhang Oct 16, 2025
6b6b54b
refactor: 调整样式
ArgoZhang Oct 16, 2025
ea156a5
chore: bump version 9.0.2
ArgoZhang Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/BootstrapBlazor.Region/BootstrapBlazor.Region.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.0.1</Version>
<Version>9.0.2</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
40 changes: 29 additions & 11 deletions src/components/BootstrapBlazor.Region/Components/SelectCity.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,18 @@
.dropdown-menu {
--bs-dropdown-padding-y: .5rem;
--bs-dropdown-padding-x: .5rem;
max-width: 400px;
max-height: 400px;
--bb-region-body-color: #495057;
--bb-region-body-hover-bg-color: #e9ecef;
--bb-region-body-active-bg-color: #dee2e6;
--bb-region-body-hover-color: #000;
--bb-region-body-active-color: #000;
--bb-region-body-width: 400px;
--bb-region-body-height: 400px;
--bb-region-body-padding: .5rem;
--bb-region-body-item-padding: 3px 12px;
--bb-region-body-gap: 5px;
width: var(--bb-region-body-width);
height: var(--bb-region-body-height);
Comment on lines +22 to +23
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces the previous max-width/max-height with fixed width/height, which alters the component's behavior (potentially introducing excess whitespace for small content and constraining growth for larger content). To preserve prior behavior and avoid a breaking visual change, use max-width and max-height with the new variables.

Suggested change
width: var(--bb-region-body-width);
height: var(--bb-region-body-height);
max-width: var(--bb-region-body-width);
max-height: var(--bb-region-body-height);

Copilot uses AI. Check for mistakes.
overflow-y: auto;
}

Expand All @@ -19,37 +29,45 @@
padding: 0;
display: flex;
flex-wrap: wrap;
gap: 5px;
gap: var(--bb-region-body-gap);
}

.dropdown-menu li {
list-style: none;
transition: background-color .3s linear, color .3s linear;
cursor: pointer;
padding: 3px 12px;
padding: var(--bb-region-body-item-padding);
border-radius: var(--bs-border-radius);
color: #777;
color: var(--bb-region-body-color);
}

.dropdown-menu li:hover {
background-color: #e9ecef;
color: #000;
background-color: var(--bb-region-body-hover-bg-color);
color: var(--bb-region-body-hover-color);
}

Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Add a :focus-visible state for .dropdown-menu li to match hover styling so keyboard users can see focus, e.g., .dropdown-menu li:focus-visible { background-color: var(--bb-region-body-hover-bg-color); color: var(--bb-region-body-hover-color); outline: 0; }.

Suggested change
.dropdown-menu li:focus-visible {
background-color: var(--bb-region-body-hover-bg-color);
color: var(--bb-region-body-hover-color);
outline: 0;
}

Copilot uses AI. Check for mistakes.
.dropdown-menu li.active {
background-color: #e3e3e3;
color: #000;
background-color: var(--bb-region-body-active-bg-color);
color: var(--bb-region-body-active-color);
}

[data-bs-theme="dark"] .dropdown-menu {
--bb-region-body-color: #ddd;
--bb-region-body-hover-color: #fff;
--bb-region-body-active-color: #fff;
--bb-region-body-hover-bg-color: #495057;
--bb-region-body-active-bg-color: #6c757d;
}

.bb-region-city-item:not(:last-child) {
margin-bottom: 3px;
padding-bottom: 3px;
border-bottom: 1px solid var(--bs-border-color);
}

.bb-region-city-title {
padding: 3px 12px;
color: #000;
padding: var(--bb-region-body-item-padding);
color: var(--bb-region-body-color);
font-weight: bold;
cursor: pointer;
}
52 changes: 37 additions & 15 deletions src/components/BootstrapBlazor.Region/Components/SelectRegion.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@

.dropdown-menu {
--bs-dropdown-padding-y: 0;
--bb-region-header-padding: 3px 12px;
--bb-region-header-hover-bg-color: #e9ecef;
--bb-region-header-active-bg-color: #dee2e6;
--bb-region-body-color: #495057;
--bb-region-body-hover-bg-color: #e9ecef;
--bb-region-body-active-bg-color: #dee2e6;
--bb-region-body-hover-color: #000;
--bb-region-body-active-color: #000;
--bb-region-body-width: 400px;
--bb-region-body-padding: .5rem;
--bb-region-body-item-padding: 3px 12px;
--bb-region-body-gap: 5px;
Comment on lines +11 to +22
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] New CSS custom properties form part of the component's theming surface. Please document each variable (purpose, default value, and examples, including dark theme overrides), so consumers know how to customize Region styling.

Copilot uses AI. Check for mistakes.
}

.dropdown-menu ul {
Expand All @@ -20,8 +32,18 @@
transition: background-color .3s linear, color .3s linear;
}

[data-bs-theme="dark"] .dropdown-menu {
--bb-region-header-hover-bg-color: #495057;
--bb-region-header-active-bg-color: #6c757d;
--bb-region-body-color: #ddd;
--bb-region-body-hover-color: #fff;
--bb-region-body-active-color: #fff;
--bb-region-body-hover-bg-color: #495057;
--bb-region-body-active-bg-color: #6c757d;
}

.bb-region-header {
width: 400px;
width: var(--bb-region-body-width);
border-bottom: 1px solid var(--bs-border-color);
}

Expand All @@ -35,48 +57,48 @@

.bb-region-header ul li {
cursor: pointer;
padding: 3px 12px;
padding: var(--bb-region-header-padding);
border-radius: var(--bs-border-radius);
}

.bb-region-header ul li.active {
background-color: #e3e3e3;
color: #000;
background-color: var(--bb-region-header-active-bg-color);
color: var(--bb-region-body-active-color);
}

.bb-region-header ul li:hover {
background-color: #e3e3e3;
color: #000;
background-color: var(--bb-region-header-hover-bg-color);
color: var(--bb-region-body-hover-color);
Comment on lines +65 to +71
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Header state text colors are sourced from body variables, which couples header styling to body settings. Consider introducing header-specific text color variables (e.g., --bb-region-header-hover-color and --bb-region-header-active-color) and referencing them here to keep header styling self-contained and easier to theme independently.

Copilot uses AI. Check for mistakes.
}

.bb-region-body {
padding: .5rem;
width: 400px;
padding: var(--bb-region-body-padding);
width: var(--bb-region-body-width);
}

.bb-region-body ul {
display: flex;
flex-wrap: wrap;
gap: 5px;
gap: var(--bb-region-body-gap);
}

.bb-region-body .bb-region-body-item:not(.active) {
display: none;
}

.bb-region-body ul li {
padding: 3px 12px;
padding: var(--bb-region-body-item-padding);
border-radius: var(--bs-border-radius);
color: var(--bb-region-body-color);
cursor: pointer;
color: #777;
}

.bb-region-body ul li:hover {
background-color: #e9ecef;
color: #000;
background-color: var(--bb-region-body-hover-bg-color);
color: var(--bb-region-body-hover-color);
}
Comment on lines 96 to 99
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Interactive items have hover and active states but no visible keyboard focus state. Add :focus-visible styles aligned with hover for keyboard accessibility, e.g., .bb-region-body ul li:focus-visible { background-color: var(--bb-region-body-hover-bg-color); color: var(--bb-region-body-hover-color); outline: 0; } and similarly for .bb-region-header ul li.

Copilot uses AI. Check for mistakes.

.bb-region-body ul li.active {
background-color: #e3e3e3;
color: #000;
background-color: var(--bb-region-body-active-bg-color);
color: var(--bb-region-body-active-color);
}