Skip to content

feat(MindMap): bump version 9.1.7#596

Merged
ArgoZhang merged 3 commits intomasterfrom
refactor-mindmap
Oct 12, 2025
Merged

feat(MindMap): bump version 9.1.7#596
ArgoZhang merged 3 commits intomasterfrom
refactor-mindmap

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Oct 12, 2025

Link issues

fixes #595

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump MindMap component to version 9.1.7 and address related script initialization issues

Bug Fixes:

  • Fix ResizeObserver callback signature to avoid unused parameter
  • Remove redundant CSS injection in MindMap initializer

Build:

  • :

Copilot AI review requested due to automatic review settings October 12, 2025 03:09
@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 12, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Oct 12, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Oct 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR bumps the MindMap component version to 9.1.7, removes an obsolete CSS inclusion, and streamlines the ResizeObserver callback in the client-side initialization script.

Class diagram for MindMap client-side initialization changes

classDiagram
class MindMap {
  +setFullData(d)
  +resize()
}
class Themes {
  +init(MindMap)
}
class ResizeObserver {
  +observe(el)
}
MindMap <.. Themes : uses
MindMap <.. ResizeObserver : observed by
Loading

Flow diagram for MindMap initialization after CSS removal

flowchart TD
    A["init(id, invoke, data, options)"] --> B["Get element by id"]
    B --> C{"Element exists?"}
    C -- No --> D["Return"]
    C -- Yes --> E["Themes.init(MindMap)"]
    E --> F["Create MindMap instance"]
    F --> G{"Data provided?"}
    G -- Yes --> H["mindMap.setFullData(d)"]
    G -- No --> I["Continue"]
    H --> J["Setup ResizeObserver"]
    I --> J
    J --> K["observer.observe(el)"]
Loading

File-Level Changes

Change Details Files
Removed redundant CSS loading call
  • Deleted await addLink('./_content/BootstrapBlazor.MindMap/mindmap.css') from init function
src/components/BootstrapBlazor.MindMap/MindMap.razor.js
Simplified ResizeObserver callback signature
  • Changed observer callback from e => mindMap.resize() to () => mindMap.resize()
src/components/BootstrapBlazor.MindMap/MindMap.razor.js
Version bump to 9.1.7
  • Updated version number in BootstrapBlazor.MindMap.csproj
src/components/BootstrapBlazor.MindMap/BootstrapBlazor.MindMap.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#595 Bump the version of the MindMap component to 9.1.7. The diff does not show any change to the version number in the project file (BootstrapBlazor.MindMap.csproj) or any other relevant location. Only code changes in MindMap.razor.js are shown, but no version bump is present.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Version bump from 9.1.6 to 9.1.7 for the MindMap component, removing CSS loading dependency and unused imports while simplifying the ResizeObserver callback.

  • Version increment in project file from 9.1.6 to 9.1.7
  • Removal of CSS loading mechanism and utility import
  • Simplification of ResizeObserver callback parameter

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
MindMap.razor.js Removed unused import and CSS loading, simplified ResizeObserver callback
BootstrapBlazor.MindMap.csproj Updated version number from 9.1.6 to 9.1.7

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 52b6b81 into master Oct 12, 2025
2 checks passed
@ArgoZhang ArgoZhang deleted the refactor-mindmap branch October 12, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(MindMap): bump version 9.1.7

2 participants