Skip to content

feat(Socket): update namesapce#558

Merged
ArgoZhang merged 3 commits intomasterfrom
feat-socket
Aug 29, 2025
Merged

feat(Socket): update namesapce#558
ArgoZhang merged 3 commits intomasterfrom
feat-socket

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Aug 29, 2025

Link issues

fixes #557

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update data converter namespaces in the Socket extension, clean up unused imports, and adjust unit tests accordingly to fix issue #557.

Bug Fixes:

Enhancements:

  • Rename Socket data converter namespace from BootstrapBlazor.Socket.DataConverter to BootstrapBlazor.Socket.DataConverters
  • Remove unused using directives in converter classes

Tests:

  • Remove obsolete using directives in BinConverterTest and HexConverterTest to match updated namespaces

Copilot AI review requested due to automatic review settings August 29, 2025 01:12
@bb-auto bb-auto Bot added the enhancement New feature or request label Aug 29, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Aug 29, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates namespace references for BootstrapBlazor Socket components to organize data converter classes under more specific namespaces. The changes involve moving data converters to the BootstrapBlazor.Socket.DataConverters namespace and updating references accordingly.

  • Moves data converter classes to the BootstrapBlazor.Socket.DataConverters namespace
  • Updates project references and using statements to match the new namespace structure
  • Increments the version number to 9.0.6

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
UnitTestTcpSocket.csproj Updates using includes to reference new Socket-prefixed namespaces
HexConverterTest.cs Removes explicit using statement for old namespace (now handled globally)
BinConverterTest.cs Removes explicit using statement for old namespace (now handled globally)
HexConverter.cs Updates namespace from DataConverter to DataConverters
BinConverter.cs Updates namespace and removes unused System.Text import
BootstrapBlazor.Socket.csproj Increments version from 9.0.5 to 9.0.6
Comments suppressed due to low confidence (1)

src/extensions/BootstrapBlazor.Socket/DataConverter/BinConverter.cs:1

  • The namespace 'BootstrapBlazorSocket.DataConverter' contains a typo - it's missing the dot between 'BootstrapBlazor' and 'Socket'. It should be 'BootstrapBlazor.Socket.DataConverter'.
// Copyright (c) BootstrapBlazor & Argo Zhang (argo@live.ca). All rights reserved.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit 1596adc into master Aug 29, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-socket branch August 29, 2025 01:12
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Socket): update namesapce

2 participants