Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates namespace references for BootstrapBlazor Socket components to organize data converter classes under more specific namespaces. The changes involve moving data converters to the BootstrapBlazor.Socket.DataConverters namespace and updating references accordingly.
- Moves data converter classes to the
BootstrapBlazor.Socket.DataConvertersnamespace - Updates project references and using statements to match the new namespace structure
- Increments the version number to 9.0.6
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| UnitTestTcpSocket.csproj | Updates using includes to reference new Socket-prefixed namespaces |
| HexConverterTest.cs | Removes explicit using statement for old namespace (now handled globally) |
| BinConverterTest.cs | Removes explicit using statement for old namespace (now handled globally) |
| HexConverter.cs | Updates namespace from DataConverter to DataConverters |
| BinConverter.cs | Updates namespace and removes unused System.Text import |
| BootstrapBlazor.Socket.csproj | Increments version from 9.0.5 to 9.0.6 |
Comments suppressed due to low confidence (1)
src/extensions/BootstrapBlazor.Socket/DataConverter/BinConverter.cs:1
- The namespace 'BootstrapBlazorSocket.DataConverter' contains a typo - it's missing the dot between 'BootstrapBlazor' and 'Socket'. It should be 'BootstrapBlazor.Socket.DataConverter'.
// Copyright (c) BootstrapBlazor & Argo Zhang (argo@live.ca). All rights reserved.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #557
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update data converter namespaces in the Socket extension, clean up unused imports, and adjust unit tests accordingly to fix issue #557.
Bug Fixes:
Enhancements:
Tests: