Skip to content

feat(Socket): HexConvert method support upper and lower case #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 3 commits into from
Aug 27, 2025
Merged

feat(Socket): HexConvert method support upper and lower case #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8d0d64
refactor: 精简代码逻辑
ArgoZhang Aug 27, 2025
54a14e8
refactor: 代码格式化
ArgoZhang Aug 27, 2025
cf874f0
feat: 增加 upper 参数支持大小写
ArgoZhang Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/extensions/BootstrapBlazor.Socket/DataConverter/HexConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
// Website: https://www.blazor.zone or https://argozhang.github.io/

using System.Text;

namespace BootstrapBlazor.Components.DataConverter;

/// <summary>
Expand All @@ -17,8 +15,9 @@ public static class HexConverter
/// </summary>
/// <param name="bytes">The byte array to convert.</param>
/// <param name="separator"></param>
/// <param name="upper"></param>
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XML documentation for the 'upper' parameter is incomplete. It should describe what the parameter does, e.g., '/// True for uppercase hexadecimal letters (A-F), false for lowercase (a-f).'

Suggested change
/// <param name="upper"></param>
/// <param name="upper">True for uppercase hexadecimal letters (A-F), false for lowercase (a-f).</param>

Copilot uses AI. Check for mistakes.
/// <returns>A string containing the hexadecimal representation of the byte array.</returns>
Comment on lines 16 to 19
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider documenting the new 'upper' parameter in the XML summary for clarity.

Updating the XML summary to explain how 'upper' affects the output will improve maintainability.

Suggested change
/// <param name="bytes">The byte array to convert.</param>
/// <param name="separator"></param>
/// <param name="upper"></param>
/// <returns>A string containing the hexadecimal representation of the byte array.</returns>
/// <param name="bytes">The byte array to convert.</param>
/// <param name="separator">The separator to use between hexadecimal byte values.</param>
/// <param name="upper">If true, returns the hexadecimal string in uppercase; if false, returns it in lowercase.</param>
/// <returns>A string containing the hexadecimal representation of the byte array.</returns>

public static string ToString(byte[]? bytes, string? separator = "-")
public static string ToString(byte[]? bytes, string? separator = "-", bool upper = true)
{
if (bytes == null || bytes.Length == 0)
{
Expand All @@ -30,13 +29,7 @@ public static string ToString(byte[]? bytes, string? separator = "-")
return BitConverter.ToString(bytes);
}

var sb = new StringBuilder(bytes.Length * 3);
foreach (var b in bytes)
{
sb.Append(b.ToString("X2"));
sb.Append(separator);
}
return sb.ToString(0, sb.Length - 1);
return string.Join(separator, bytes.Select(i => upper ? i.ToString("X2") : i.ToString("x2")));
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/extensions/BootstrapBlazor.Socket/Extensions/DataPropertyExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ static class DataPropertyExtensions
{
var converterParameters = attribute.ConverterParameters;
var c = Activator.CreateInstance(converterType, converterParameters);
if(c is IDataPropertyConverter v)
if (c is IDataPropertyConverter v)
{
converter = v;
}
Expand Down