Skip to content

feat(MeilSearch): add kbd style for dark theme#522

Merged
ArgoZhang merged 2 commits intomasterfrom
refactor-meilisearch
Aug 10, 2025
Merged

feat(MeilSearch): add kbd style for dark theme#522
ArgoZhang merged 2 commits intomasterfrom
refactor-meilisearch

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Aug 10, 2025

Link issues

fixes #521

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add styling support for keyboard () elements in the MeiliSearch global search dialog footer when using dark theme.

New Features:

  • Introduce CSS rule to style elements within the search dialog mask using a custom CSS variable
  • Define --bb-global-search-footer-kbd-color for dark theme to match the body text color

@bb-auto bb-auto Bot added the enhancement New feature or request label Aug 10, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Aug 10, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR extends the global search dialog by adding dedicated styling and a CSS variable override for dark theme, and updates the project file to include these styling assets.

File-Level Changes

Change Details Files
Add styling in search dialog mask
  • Insert .search-dialog-mask kbd { color: var(--bb-global-search-footer-kbd-color); } rule
  • Define --bb-global-search-footer-kbd-color for dark theme in [data-bs-theme='dark'] .search-dialog-mask
src/components/BootstrapBlazor.MeiliSearch/wwwroot/meilisearch.css
Update project configuration to include CSS changes
  • Modify BootstrapBlazor.MeiliSearch.csproj to incorporate new styling assets
src/components/BootstrapBlazor.MeiliSearch/BootstrapBlazor.MeiliSearch.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#521 Add kbd style for dark theme in MeilSearch component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit cba58be into master Aug 10, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the refactor-meilisearch branch August 10, 2025 03:11
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Add a root-level default for --bb-global-search-footer-kbd-color or include a fallback in the var() call so the kbd color isn’t undefined outside of dark mode.
  • Verify the kbd styling remains correct when toggling between light and dark themes to avoid any flicker or unstyled states.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add a root-level default for `--bb-global-search-footer-kbd-color` or include a fallback in the var() call so the kbd color isn’t undefined outside of dark mode.
- Verify the kbd styling remains correct when toggling between light and dark themes to avoid any flicker or unstyled states.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(MeilSearch): add kbd style for dark theme

1 participant