feat(MeilSearch): add kbd style for dark theme#522
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR extends the global search dialog by adding dedicated styling and a CSS variable override for dark theme, and updates the project file to include these styling assets. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Add a root-level default for
--bb-global-search-footer-kbd-coloror include a fallback in the var() call so the kbd color isn’t undefined outside of dark mode. - Verify the kbd styling remains correct when toggling between light and dark themes to avoid any flicker or unstyled states.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add a root-level default for `--bb-global-search-footer-kbd-color` or include a fallback in the var() call so the kbd color isn’t undefined outside of dark mode.
- Verify the kbd styling remains correct when toggling between light and dark themes to avoid any flicker or unstyled states.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #521
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add styling support for keyboard () elements in the MeiliSearch global search dialog footer when using dark theme.
New Features: