Skip to content

feat(CherryMarkdown): bump version 9.0.3#490

Merged
ArgoZhang merged 2 commits intomasterfrom
feat-mk
Jul 14, 2025
Merged

feat(CherryMarkdown): bump version 9.0.3#490
ArgoZhang merged 2 commits intomasterfrom
feat-mk

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Jul 14, 2025

Link issues

fixes #489

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump CherryMarkdown to version 9.0.3 and normalize locale codes by replacing hyphens with underscores.

Bug Fixes:

  • Ensure locale identifiers use underscores instead of hyphens by normalizing op.locale in the JavaScript init function

Enhancements:

  • Update BootstrapBlazor.CherryMarkdown package version to 9.0.3 in the csproj

@bb-auto bb-auto Bot added the enhancement New feature or request label Jul 14, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 14, 2025

Reviewer's Guide

This PR upgrades the CherryMarkdown package to v9.0.3 and refines the editor initialization logic by normalizing locale codes for consistency.

Class diagram for CherryMarkdown editor initialization changes

classDiagram
    class CherryMarkdownEditor {
        +init(id, invoke, options, callback)
        +editor
    }
    CherryMarkdownEditor : +fileUpload
    CherryMarkdownEditor : +locale
    CherryMarkdownEditor : +Data.set(id, md)
    CherryMarkdownEditor : +locale normalization (replace '-' with '_')
Loading

Flow diagram for locale normalization in CherryMarkdown initialization

flowchart TD
    A[Start init function] --> B{Does op.locale exist?}
    B -- Yes --> C[Replace '-' with '_' in op.locale]
    C --> D[Continue with Cherry editor initialization]
    B -- No --> D[Continue with Cherry editor initialization]
    D --> E[Set Data with id and editor instance]
    E --> F[End]
Loading

File-Level Changes

Change Details Files
Normalize locale formatting in editor initialization
  • Check for existence of op.locale before processing
  • Replace hyphens with underscores in locale strings
  • Integrate normalized locale back into init options
src/components/BootstrapBlazor.CherryMarkdown/Components/CherryMarkdown/CherryMarkdown.razor.js
Bump package version to 9.0.3
  • Update project version property in csproj
src/components/BootstrapBlazor.CherryMarkdown/BootstrapBlazor.CherryMarkdown.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#489 Bump the CherryMarkdown version to 9.0.3.
#489 Correctly set the locale by replacing '-' with '_'.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone Jul 14, 2025
@ArgoZhang ArgoZhang merged commit 9459aeb into master Jul 14, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-mk branch July 14, 2025 03:01
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(CherryMarkdown): bump version 9.0.3

1 participant