Conversation
Reviewer's GuideThis PR upgrades the CherryMarkdown package to v9.0.3 and refines the editor initialization logic by normalizing locale codes for consistency. Class diagram for CherryMarkdown editor initialization changesclassDiagram
class CherryMarkdownEditor {
+init(id, invoke, options, callback)
+editor
}
CherryMarkdownEditor : +fileUpload
CherryMarkdownEditor : +locale
CherryMarkdownEditor : +Data.set(id, md)
CherryMarkdownEditor : +locale normalization (replace '-' with '_')
Flow diagram for locale normalization in CherryMarkdown initializationflowchart TD
A[Start init function] --> B{Does op.locale exist?}
B -- Yes --> C[Replace '-' with '_' in op.locale]
C --> D[Continue with Cherry editor initialization]
B -- No --> D[Continue with Cherry editor initialization]
D --> E[Set Data with id and editor instance]
E --> F[End]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #489
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bump CherryMarkdown to version 9.0.3 and normalize locale codes by replacing hyphens with underscores.
Bug Fixes:
Enhancements: