feat(DockView): add float window shadow style#488
Merged
Conversation
Reviewer's GuideAdds a custom shadow style for floating DockView windows in the light theme by introducing a new CSS variable and refines container styling, plus synchronizes project files for related components. Class diagram for updated DockView CSS variables and structureclassDiagram
class DockViewThemeLight {
+--dv-floating-box-shadow: string
}
class DVResizeContainer {
+border: none
+border-radius: var(--bs-border-radius)
+overflow: hidden
}
DockViewThemeLight <|-- DVResizeContainer: uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Ensure the newly defined
--dv-floating-box-shadowis actually applied (e.g. viabox-shadow: var(--dv-floating-box-shadow)) on the floating window selector so the shadow shows up. - Consider adding a matching shadow override for the dark theme so floating windows get consistent styling across both light and dark modes.
- After removing the border on
.dv-resize-container, verify that the resize handles remain clearly visible and usable against various background colors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the newly defined `--dv-floating-box-shadow` is actually applied (e.g. via `box-shadow: var(--dv-floating-box-shadow)`) on the floating window selector so the shadow shows up.
- Consider adding a matching shadow override for the dark theme so floating windows get consistent styling across both light and dark modes.
- After removing the border on `.dv-resize-container`, verify that the resize handles remain clearly visible and usable against various background colors.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #487
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add shadow styling for floating windows in the DockView light theme and refine the resize container appearance by removing its border and adding rounded corners with overflow hidden.
New Features:
Enhancements: