Skip to content

feat(DockView): add float window shadow style#488

Merged
ArgoZhang merged 4 commits intomasterfrom
feat-dockview
Jul 14, 2025
Merged

feat(DockView): add float window shadow style#488
ArgoZhang merged 4 commits intomasterfrom
feat-dockview

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Jul 14, 2025

Link issues

fixes #487

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add shadow styling for floating windows in the DockView light theme and refine the resize container appearance by removing its border and adding rounded corners with overflow hidden.

New Features:

  • Add floating window shadow style to DockView light theme

Enhancements:

  • Remove border from resize container and apply border radius with overflow hidden

@bb-auto bb-auto Bot added the enhancement New feature or request label Jul 14, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 14, 2025

Reviewer's Guide

Adds a custom shadow style for floating DockView windows in the light theme by introducing a new CSS variable and refines container styling, plus synchronizes project files for related components.

Class diagram for updated DockView CSS variables and structure

classDiagram
    class DockViewThemeLight {
        +--dv-floating-box-shadow: string
    }
    class DVResizeContainer {
        +border: none
        +border-radius: var(--bs-border-radius)
        +overflow: hidden
    }
    DockViewThemeLight <|-- DVResizeContainer: uses
Loading

File-Level Changes

Change Details Files
Enhance floating window styling and container layout in DockView CSS
  • Introduce --dv-floating-box-shadow rule under .dockview-theme-light
  • Remove default border, add border-radius and set overflow to hidden on dv-resize-container
  • Add missing newline at end of CSS file
src/components/BootstrapBlazor.DockView/wwwroot/css/dockview-bb.css
Refresh component project files
  • Touch CherryMarkdown project file
  • Touch DockView project file
src/components/BootstrapBlazor.CherryMarkdown/BootstrapBlazor.CherryMarkdown.csproj
src/components/BootstrapBlazor.DockView/BootstrapBlazor.DockView.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#487 Add a shadow style to the float window in the DockView component.

Possibly linked issues

  • feat(DockView): add float window shadow style #487: The PR adds the requested float window shadow style and modifies the resize container border in the DockView CSS.
  • #0: The PR adds overflow: hidden to the resize container, which directly addresses the issue's request for overflow style.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone Jul 14, 2025
@ArgoZhang ArgoZhang merged commit 57ccadb into master Jul 14, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-dockview branch July 14, 2025 02:38
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Ensure the newly defined --dv-floating-box-shadow is actually applied (e.g. via box-shadow: var(--dv-floating-box-shadow)) on the floating window selector so the shadow shows up.
  • Consider adding a matching shadow override for the dark theme so floating windows get consistent styling across both light and dark modes.
  • After removing the border on .dv-resize-container, verify that the resize handles remain clearly visible and usable against various background colors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the newly defined `--dv-floating-box-shadow` is actually applied (e.g. via `box-shadow: var(--dv-floating-box-shadow)`) on the floating window selector so the shadow shows up.
- Consider adding a matching shadow override for the dark theme so floating windows get consistent styling across both light and dark modes.
- After removing the border on `.dv-resize-container`, verify that the resize handles remain clearly visible and usable against various background colors.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(DockView): add float window shadow style

1 participant