feat(CherryMarkdown): add Language parameter#486
Merged
Conversation
|
Thanks for your PR, @MadLongTom. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's GuideIntroduces a new Locale parameter to the CherryMarkdown component and integrates it into the JavaScript initialization call to enable language customization. Sequence diagram for CherryMarkdown initialization with Locale parametersequenceDiagram
participant CherryMarkdown
participant JSInterop
CherryMarkdown->>JSInterop: InvokeVoidAsync("init", Id, Interop, { Value, IsSupportMath, IsViewer, Locale, Editor, Toolbars }, "Upload")
Note right of JSInterop: JS receives Locale for language customization
Class diagram for CherryMarkdown with new Locale parameterclassDiagram
class CherryMarkdown {
+bool IsViewer
+string Locale = "zh-CN"
+Task InvokeInitAsync()
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @MadLongTom - I've reviewed your changes - here's some feedback:
- Ensure the corresponding JavaScript init function is updated to consume and apply the new Locale parameter when rendering.
- Consider constraining Locale to a predefined list of supported culture codes or using an enum to avoid invalid string values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the corresponding JavaScript init function is updated to consume and apply the new Locale parameter when rendering.
- Consider constraining Locale to a predefined list of supported culture codes or using an enum to avoid invalid string values.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #485
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add locale parameter to CherryMarkdown component to support customizable language
New Features:
Enhancements: