Skip to content

feat(EFCore): bump version 9.0.1#484

Merged
ArgoZhang merged 4 commits intomasterfrom
feat-ef
Jul 10, 2025
Merged

feat(EFCore): bump version 9.0.1#484
ArgoZhang merged 4 commits intomasterfrom
feat-ef

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Jul 10, 2025

Link issues

fixes #483

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump EFCore data access extension to v9.0.1 and ensure query results are fully materialized by converting items to a List before returning.

Bug Fixes:

  • Materialize query results in QueryAsync by converting items to a concrete List to avoid deferred execution issues.

Chores:

  • Bump BootstrapBlazor.DataAccess.EntityFrameworkCore package version to 9.0.1.

@bb-auto bb-auto Bot added the enhancement New feature or request label Jul 10, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Jul 10, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jul 10, 2025

Reviewer's Guide

This PR updates the Entity Framework Core dependency to version 9.0.1, adjusts query materialization to avoid deferred execution, and applies a minor formatting cleanup.

Class diagram for DefaultDataService changes

classDiagram
    class DefaultDataService {
        +Task EditAsync(object model)
        +Task<QueryData<TModel>> QueryAsync(QueryPageOptions option)
    }
    class QueryData~TModel~ {
        +int TotalCount
        +List<TModel> Items
        +bool IsSorted
        +bool IsFiltered
        +bool IsAdvanceSearch
    }
    class QueryPageOptions {
        +SortOrder SortOrder
        +List<Filter> Filters
        +List<AdvanceSearch> AdvanceSearches
    }
    DefaultDataService --> QueryData~TModel~
    DefaultDataService --> QueryPageOptions
    QueryData~TModel~ o-- TModel
    QueryPageOptions o-- Filter
    QueryPageOptions o-- AdvanceSearch
    QueryPageOptions --> SortOrder
Loading

File-Level Changes

Change Details Files
Bump EF Core package to 9.0.1
  • Updated EF Core package reference version
  • Synchronized solution/project files with new dependency
BootstrapBlazor.DataAccess.EntityFrameworkCore.csproj
BootstrapBlazor.Extensions.sln
Materialize query results before returning
  • Changed Items assignment to use ToList() for eager evaluation
DefaultDataService.cs
Minor formatting cleanup
  • Removed extraneous trailing whitespace after closing brace
DefaultDataService.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#483 Bump the EFCore version to 9.0.1.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit ebc9206 into master Jul 10, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-ef branch July 10, 2025 04:13
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

  • Consider making QueryAsync fully asynchronous by replacing items.ToList() with await items.ToListAsync(), marking the method async to avoid blocking threads.
  • The whitespace-only change around the closing brace isn’t functionally necessary; consider reverting it to keep the diff focused on meaningful changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making QueryAsync fully asynchronous by replacing items.ToList() with await items.ToListAsync(), marking the method async to avoid blocking threads.
- The whitespace-only change around the closing brace isn’t functionally necessary; consider reverting it to keep the diff focused on meaningful changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(EFCore): bump version 9.0.1

1 participant