feat(DockView): add overflow style for floating window#471
Merged
Conversation
Reviewer's GuideThis PR upgrades dockview to v4.3.1, reconciles CSS & JS API changes for renamed targets and layout options, adds overflow handling for panels, and refactors duplicated CSS rules. Sequence Diagram: Emitter Event Firing with Replay OptionsequenceDiagram
participant ClientCode
participant Emitter
ClientCode->>Emitter: new Emitter({ replay: true })
ClientCode->>Emitter: fire(eventData)
activate Emitter
Note right of Emitter: Stores eventData as _last if options.replay is true
Emitter-->>ClientCode: (listeners notified)
deactivate Emitter
Sequence Diagram: Popout Panel with Optional Reference GroupsequenceDiagram
participant User
participant DockviewComponent
participant ItemToPopout
User->>DockviewComponent: Initiate Popout (itemToPopout, options: { referenceGroup: refGroup })
activate DockviewComponent
DockviewComponent->>DockviewComponent: Determine referenceGroup (from options or itemToPopout)
DockviewComponent->>DockviewComponent: Create Popout Window/Group (using referenceGroup)
DockviewComponent-->>User: Popout Window Displayed
deactivate DockviewComponent
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @zhaijunlei955. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Hey @zhaijunlei955 - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/components/BootstrapBlazor.DockView/wwwroot/css/dockview.css:1060` </location>
<code_context>
-.dv-tab.dv-inactive-tab .dv-default-tab:hover .dv-default-tab-action {
- visibility: visible;
-}
-.dv-tab .dv-default-tab {
- position: relative;
- height: 100%;
</code_context>
<issue_to_address>
Add overflow:hidden to enable text-overflow ellipsis
`text-overflow: ellipsis` needs `overflow: hidden;` to work. Please add it to this rule.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
.dv-tab .dv-default-tab {
position: relative;
height: 100%;
=======
.dv-tab .dv-default-tab {
position: relative;
height: 100%;
overflow: hidden;
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ArgoZhang
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #472
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Upgrade Dockview to v4.3.1 with upstream bug fixes, event enhancements, popup improvements, and CSS cleanups
New Features:
Bug Fixes:
Enhancements:
Chores: