Skip to content

feat(Vditor): support validate form#468

Merged
ArgoZhang merged 2 commits intomasterfrom
feat-vditor
Jun 14, 2025
Merged

feat(Vditor): support validate form#468
ArgoZhang merged 2 commits intomasterfrom
feat-vditor

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Jun 14, 2025

Link issues

fixes #467

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add form validation support to the Vditor component by exposing validation CSS classes and updating styles

New Features:

  • Expose validation state classes (is-valid, is-invalid) on the Vditor component

Enhancements:

  • Update JS to load the renamed vditor.css asset instead of index.css

@bb-auto bb-auto Bot added the enhancement New feature or request label Jun 14, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 14, 2025

Reviewer's Guide

Enhance the Vditor component to support form validation by extending its CSS class builder, updating the client initialization script to load a new stylesheet, and adding validation styles in a dedicated CSS file.

Sequence diagram: Vditor client-side CSS loading updated to vditor.css

sequenceDiagram
    participant Browser
    participant VditorInitJS as "Vditor.razor.js"

    Browser->>VditorInitJS: Call init()
    activate VditorInitJS
    VditorInitJS->>Browser: Load CSS "./_content/BootstrapBlazor.Vditor/css/vditor.css (New path)"
    VditorInitJS->>Browser: Load JS "./_content/BootstrapBlazor.Vditor/js/vditor.js"
    VditorInitJS-->>Browser: Initialization continues
    deactivate VditorInitJS
Loading

Class diagram: Vditor component - ClassString property updated for validation styling

classDiagram
  class Vditor {
    +CssClass: string
    +ValidCss: string
    +AdditionalAttributes: object
    +ClassString: string
  }
  %% The ClassString property's getter logic is updated to use CssClass, ValidCss, and AdditionalAttributes for form validation styling. %%
Loading

File-Level Changes

Change Details Files
Extend component class builder to include validation classes
  • Add .AddClass(CssClass) to the CssBuilder chain
  • Add .AddClass(ValidCss) to include validation state classes
src/components/BootstrapBlazor.Vditor/Vditor.razor.cs
Update initialization script to load new stylesheet
  • Replace './_content/BootstrapBlazor.Vditor/css/index.css' with './_content/BootstrapBlazor.Vditor/css/vditor.css' in addLink call
src/components/BootstrapBlazor.Vditor/Vditor.razor.js
Add vditor.css with validation styling
  • Import base index.css at top
  • Define .bb-vditor.is-invalid border-color using var(--bs-danger)
  • Define .bb-vditor.is-valid border-color using var(--bs-success)
src/components/BootstrapBlazor.Vditor/wwwroot/css/vditor.css

Assessment against linked issues

Issue Objective Addressed Explanation
#467 Support form validation for the Vditor component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone Jun 14, 2025
@ArgoZhang ArgoZhang merged commit 4093d67 into master Jun 14, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-vditor branch June 14, 2025 09:20
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Vditor): support validate form

1 participant