feat(PdfViewer): add UseGoogleDocs parameter#454
Merged
Conversation
Reviewer's GuideIntroduces a new UseGoogleDocs toggle to the PdfViewer component, with component-level state tracking and updates to both Razor and JS interop to optionally render PDFs via the Google Docs viewer and to reinitialize the viewer when this flag or the URL changes. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Use HTTPS and encode the PDF URL when constructing the Google Docs viewer link to avoid mixed-content issues and ensure valid URLs.
- The manual state-tracking in OnAfterRenderAsync for _url and _useGoogleDocs could be simplified by overriding ShouldRender or leveraging Blazor’s built-in change detection.
- Re-add clearing logic for when Url is null or empty, as removing the else branch in loadPdf may leave old frames in place when no URL is provided.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+36
to
+38
| if (useGoogleDocs) { | ||
| url = `http://docs.google.com/viewer?url=${url}` | ||
| } |
There was a problem hiding this comment.
suggestion (bug_risk): Use HTTPS and encode URL when loading Google Docs viewer
Update the protocol to https:// and use encodeURIComponent(url) to prevent mixed-content errors and handle special characters in the URL.
Suggested change
| if (useGoogleDocs) { | |
| url = `http://docs.google.com/viewer?url=${url}` | |
| } | |
| if (useGoogleDocs) { | |
| url = `https://docs.google.com/viewer?url=${encodeURIComponent(url)}` | |
| } |
| private string? _url; | ||
| private bool _useGoogleDocs; | ||
|
|
||
| private string? UseGoogleDocsString => UseGoogleDocs ? "true" : null; |
There was a problem hiding this comment.
issue (complexity): Consider removing the unused property and simplifying the rerender logic in OnAfterRenderAsync with a single if/else block.
// 1) Remove the unused property
// private string? UseGoogleDocsString => UseGoogleDocs ? "true" : null;
// 2) Collapse OnAfterRenderAsync into a single if/else
protected override async Task OnAfterRenderAsync(bool firstRender)
{
await base.OnAfterRenderAsync(firstRender);
if (firstRender)
{
_url = Url;
_useGoogleDocs = UseGoogleDocs;
}
else if (_url != Url || _useGoogleDocs != UseGoogleDocs)
{
_url = Url;
_useGoogleDocs = UseGoogleDocs;
await InvokeVoidAsync("loadPdf", Id, _url);
}
}These two changes preserve all behavior while removing dead code and flattening the rerender logic.
|
|
||
| const useGoogleDocs = el.getAttribute('data-bb-google-docs') === 'true'; | ||
| if (useGoogleDocs) { | ||
| url = `http://docs.google.com/viewer?url=${url}` |
There was a problem hiding this comment.
issue (code-quality): Don't reassign parameter - url (dont-reassign-parameters)
Explanation
Reassigning parameters can lead to unexpected behavior, especially when accessing the arguments object. It can also cause optimization issues, especially in V8.From the Airbnb JavaScript Style Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #453
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce a new UseGoogleDocs parameter and update the interop logic to load PDFs via Google Docs when enabled, while ensuring the viewer is properly reinitialized on configuration changes.
New Features:
Enhancements: