Skip to content

refactor(SummerNote): update form label style#440

Merged
ArgoZhang merged 3 commits intomasterfrom
refactor-editor
May 21, 2025
Merged

refactor(SummerNote): update form label style#440
ArgoZhang merged 3 commits intomasterfrom
refactor-editor

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented May 21, 2025

Link issues

fixes #439

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix inconsistent spacing for form labels, groups, and checkbox inputs in SummerNote editor

@bb-auto bb-auto Bot added the enhancement New feature or request label May 21, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 21, 2025

Reviewer's Guide

This PR refactors the SummerNote editor’s form label styling by introducing consistent bottom margins for form groups, labels, file-select groups, and checkbox inputs, and updates the project file to include these style changes.

File-Level Changes

Change Details Files
Refactored form group and label spacing in the editor CSS
  • Added bottom margin to all .note-form-group elements in modals except the last child
  • Introduced .5rem bottom margin for .note-form-label and .note-group-select-from-files
  • Adjusted right margin on checkbox inputs for the open-in-new-window option
src/components/BootstrapBlazor.SummerNote/wwwroot/css/editor.css
Updated project configuration to include the revised styles
  • Modified csproj to embed and reference the updated editor.css resource
src/components/BootstrapBlazor.SummerNote/BootstrapBlazor.SummerNote.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#439 Update the form label style in the SummerNote editor.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone May 21, 2025
@ArgoZhang ArgoZhang merged commit d80014b into master May 21, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the refactor-editor branch May 21, 2025 06:49
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

margin-bottom: .5rem;
}

.form-check sn-checkbox-open-in-new-window .form-check-input {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Missing . before sn-checkbox-open-in-new-window in selector

Add a . before sn-checkbox-open-in-new-window so it targets a class, e.g.: .form-check .sn-checkbox-open-in-new-window .form-check-input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(SummerNote): update form label style

1 participant