feat(Playwright): add BootstrapBlazor.Html2Pdf.Playwright project#435
Merged
feat(Playwright): add BootstrapBlazor.Html2Pdf.Playwright project#435
Conversation
Reviewer's GuideThis pull request introduces a new project, File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Consider managing the Playwright browser instance lifecycle outside of individual PDF generation requests to improve performance and resource usage.
- Consider allowing PDF generation options like format and orientation to be configured instead of being hardcoded.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| Args = ["--no-sandbox", "--disable-setuid-sandbox", "--disable-web-security"] | ||
| }; | ||
|
|
||
| private static async Task AddStyleTagAsync(IPage page, IEnumerable<string>? links = null) |
There was a problem hiding this comment.
issue (complexity): Consider iterating directly over the input enumerable in AddStyleTagAsync and AddScriptTagAsync to avoid creating intermediate lists.
Consider simplifying the tag helpers to avoid creating intermediate lists. For example, you can iterate directly over the supplied enumerable. This reduces unnecessary nesting and improves readability without changing functionality. Here's a suggestion:
private static async Task AddStyleTagAsync(IPage page, IEnumerable<string>? links = null)
{
if (links == null) return;
foreach (var link in links)
{
await page.AddStyleTagAsync(new PageAddStyleTagOptions { Url = link });
}
}
private static async Task AddScriptTagAsync(IPage page, IEnumerable<string>? scripts = null)
{
if (scripts == null) return;
foreach (var script in scripts)
{
await page.AddScriptTagAsync(new PageAddScriptTagOptions { Url = script, Type = "script" });
}
}These concise changes remove unnecessary list instantiation while keeping functionality intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #434
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new Playwright-based HTML to PDF conversion service for the BootstrapBlazor project
New Features:
Enhancements: