Refactor plyr

[ArgoZhang]

Link issues

fixes #421

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Add support for client-side player event callbacks in the Player component.

Enhancements:

• Introduce the OnEvent parameter to receive notifications for player events (e.g., play, pause, ended, fullscreen).
• Refactor JavaScript event handling logic.

Chores:

• Reorganize JavaScript helper functions.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request refactors the Plyr player component, primarily focusing on improving event handling by introducing a .NET event callback and restructuring the JavaScript code to manage event listeners and player lifecycle methods.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Implement .NET event callback for player events.	Added OnEvent parameter in C#. Added [JSInvokable] method to receive JS events. Added data attribute to control JS event firing. Created JS functions to handle and dispatch events. Integrated event handling setup into player initialization in JS. Pass .NET method name to JS init function to enable callbacks.	src/components/BootstrapBlazor.Player/Player.razor.cs src/components/BootstrapBlazor.Player/Player.razor src/components/BootstrapBlazor.Player/Player.razor.js
Restructure JavaScript player utility functions.	Relocated functions for reloading, setting poster, and disposing. Removed a helper function for executing operations on the player instance. Updated utility functions to access player data directly.	src/components/BootstrapBlazor.Player/Player.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#421	Add an OnEvent callback to the Player component.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• The JavaScript check for the data-bb-event attribute seems redundant, as the C# TriggerEvent method already handles whether the OnEvent callback should be invoked.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)

Suggested change

	const src = source[0].src;
	const {src} = source[0];

Explanation

Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.

From the Airbnb Javascript Style Guide