feat(sdk-core): added OFC BitGo signing on wallet and coins object#8803
Merged
Conversation
alextse-bg
force-pushed
the
WCN-217
branch
2 times, most recently
from
a09e279 to
16bcfef
Compare
allow wallet and coins object to sign using the BitGo key if the passphrase is not provided during signing Ticket: WCN-217-2
mohammadalfaiyazbitgo
requested changes
May 20, 2026
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
Blocking on the walletPassphrase gap in the wallet.ts OFC path — see inline comment. Also a minor error message inconsistency in ofcToken.ts.
mohammadalfaiyazbitgo
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow wallet and coins object to sign using the BitGo key if the passphrase is not provided during signing
Ticket: WCN-217-2