feat(sdk-core): add EdDSA MPCv2 offline signing helper utils#8793
Open
vibhavgo wants to merge 1 commit into
Open
feat(sdk-core): add EdDSA MPCv2 offline signing helper utils#8793vibhavgo wants to merge 1 commit into
vibhavgo wants to merge 1 commit into
Conversation
vibhavgo
changed the title
vibhavgo
changed the title
vibhavgo
force-pushed
the
WCI-386/eddsa-util-helper
branch
from
73179bb to
f4ebbae
Compare
Marzooqa
reviewed
May 19, 2026
Marzooqa
reviewed
May 19, 2026
Marzooqa
reviewed
May 19, 2026
Marzooqa
reviewed
May 19, 2026
| * @returns void | ||
| * @throws {Error} if the adata or cyphertext is invalid | ||
| */ | ||
| private validateAdata(adata: string, cyphertext: string, roundDomainSeparator: string): void { |
Contributor
There was a problem hiding this comment.
This is byte-for-byte identical to EcdsaMPCv2Utils.validateAdata. Both classes share the same baseTSSUtils<KeyShare> ancestor, so this should be lifted there to eliminate the duplication. This is the most straightforward extraction — same signature, same body, no ECDSA/EdDSA differences.
Marzooqa
reviewed
May 19, 2026
vibhavgo
force-pushed
the
WCI-386/eddsa-util-helper
branch
from
f4ebbae to
2188290
Compare
Marzooqa
reviewed
May 19, 2026
vibhavgo
force-pushed
the
WCI-386/eddsa-util-helper
branch
from
2188290 to
6340d35
Compare
Marzooqa
reviewed
May 20, 2026
| }); | ||
| }); | ||
|
|
||
| describe('External Signing Helpers', function () { |
Contributor
There was a problem hiding this comment.
These utility helper tests (getSignableHexAndDerivationPath, validateAdata, getBitgoAndUserGpgKeys) do not belong in createKeychains.ts — this file is for testing the keychain creation flow.
More importantly, these methods now live on baseTSSUtils in sdk-core, so they should be tested there, not through an EdDSA subclass in the bitgo module. The right place is a new dedicated file: modules/sdk-core/test/unit/bitgo/utils/tss/baseTSSUtils.ts, consistent with how addressVerification.ts, ecdsaMPCv2.ts, and eddsaMPCv2.ts each have their own focused files in that directory.
Marzooqa
reviewed
May 20, 2026
vibhavgo
force-pushed
the
WCI-386/eddsa-util-helper
branch
from
6340d35 to
2facaea
Compare
Ticket: WCI-386 Centralizes shared MPCv2 helper logic in BaseTssUtils for reuse across ECDSA and EdDSA, and moves misplaced helper tests from the EdDSA keychain creation test to a dedicated BaseTssUtils test file in sdk-core. - Move getSignableHexAndDerivationPath() into BaseTssUtils for shared ECDSA and EdDSA MPCv2 transaction extraction - Move validateAdata() into BaseTssUtils to eliminate duplicated authenticated data validation - Move getBitgoAndUserGpgKeys() into BaseTssUtils with v1 (SJCL) and v2 (Argon2id) envelope support; accepts a userGpgKeyDomainSeparator arg - Remove redundant private getBitgoAndUserGpgKeys() from EcdsaMPCv2Utils and EddsaMPCv2Utils; delegate to base class - Remove unused MPS_DSG_SIGNING_USER_GPG_KEY constant and isV2Envelope import from EddsaMPCv2Utils - Remove misplaced External Signing Helpers tests from createKeychains.ts - Add sdk-core/test/unit/bitgo/utils/tss/baseTSSUtils.ts with lean, strictly typed tests for all extracted helpers and ECDSA delegation Co-authored-by: Cursor <cursoragent@cursor.com>
vibhavgo
force-pushed
the
WCI-386/eddsa-util-helper
branch
from
2facaea to
53a09b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared private utility methods to EddsaMPCv2Utils that will be used across all three createOfflineRound1/2/3Share methods. These are prerequisite helpers that centralize transaction payload extraction, GPG key handling, and authenticated data validation to prevent code duplication.
Ticket: WCI-386