Ap 602 refactor roles#46
Merged
Merged
Conversation
awilfox
reviewed
May 11, 2026
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks pretty good to me. There are a few inline comments to resolve before merging, and I'd like to review again after those are done. (I'm a bit tired today and hope to review again tomorrow with fresh eyes after these changes are made.)
awilfox
approved these changes
May 15, 2026
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
r+ nice! This is exactly how I hoped it could look. I like how the tests become simpler too in some places. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.