Skip to content

Add scoped browser compatibility review guidance for msal-browser#8582

Closed
Copilot wants to merge 1 commit intobrowser_compat_instructionsfrom
copilot/sub-pr-8525
Closed

Add scoped browser compatibility review guidance for msal-browser#8582
Copilot wants to merge 1 commit intobrowser_compat_instructionsfrom
copilot/sub-pr-8525

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

This PR adds a dedicated browser compatibility review path for msal-browser changes that touch browser Web APIs. It introduces a single compatibility reference and connects it to review instructions so the heavier guidance is consulted only for relevant lib/msal-browser/src/ changes.

  • Compatibility reference

    • Added lib/msal-browser/docs/browser-compat-map.md as the central map of browser Web API dependencies.
    • Documents:
      • affected auth flows
      • fallback behavior
      • privacy-mode and cross-browser restrictions
      • upcoming browser changes that may affect MSAL
  • Review instructions

    • Added .github/instructions/browser_compat.instructions.md for PRs that introduce, modify, or remove browser Web API usage under lib/msal-browser/src/**.
    • Focuses review on high-risk areas such as:
      • storage partitioning
      • third-party cookie restrictions
      • popup / iframe behavior
      • CSP / COOP / framing constraints
  • Documentation workflow

    • Updated .github/instructions/doc_review.instructions.md to require keeping the compatibility map in sync with browser API usage changes.
    • Updated AGENTS.md to point reviewers and agents to the compatibility map and clarify when the instruction applies.
  • Scope control

    • The compatibility map is not intended for every review.
    • The instruction is scoped so the map is read only when a lib/msal-browser/src/ change introduces, changes, or removes a browser Web API dependency.

Example of the new review trigger:

When a change to `lib/msal-browser/src/` introduces, modifies, or removes a browser Web API call, review the Browser Compatibility Map for known restrictions and flow dependencies.

Copilot AI changed the title [WIP] Add browser compatibility guidelines and review instructions for msal-browser Add scoped browser compatibility review guidance for msal-browser May 7, 2026
Copilot AI requested a review from konstantin-msft May 7, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants