[ARO] az aro create: Fix default worker-vm-size if not provided#33508
Open
komidore64 wants to merge 1 commit into
Open
[ARO] az aro create: Fix default worker-vm-size if not provided#33508komidore64 wants to merge 1 commit into
az aro create: Fix default worker-vm-size if not provided#33508komidore64 wants to merge 1 commit into
Conversation
komidore64
requested review from
Pan-Qi,
VeryEarly,
jsntcy and
necusjz
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the default worker VM size behavior for ARO create and adjusts the CLI parameter help text accordingly.
Changes:
- Sets a default value for
worker_vm_sizeinaro_create. - Removes the explicit default mention from the
--worker-vm-sizehelp text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/aro/custom.py | Changes aro_create default for worker_vm_size to Standard_D4s_v5. |
| src/azure-cli/azure/cli/command_modules/aro/_params.py | Updates CLI help text for worker_vm_size by removing the default note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| master_vm_size=None, | ||
| worker_encryption_at_host=False, | ||
| worker_vm_size=None, | ||
| worker_vm_size="Standard_D4s_v5", |
| help='Encryption at host flag for worker VMs. [Default: false]') | ||
| c.argument('worker_vm_size', | ||
| help='Size of worker VMs. [Default: Standard_D4s_v5]') | ||
| help='Size of worker VMs.') |
Author
There was a problem hiding this comment.
The CLI help detects the keyword argument default and displays it as part of the flag's help text.
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution @komidore64! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
If
--worker-vm-sizeis not provided toaz aro createa default value should be set.Testing Guide
Create an ARO cluster without passing
--worker-vm-sizeflag. It should create the cluster without returning an error for empty worker VM size.History Notes
Worker VM size is intended to provide a fallback default.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.