chore(analytics): remove dead Amplitude events and LISTEN_GATED#14304
Open
dylanjeffers wants to merge 3 commits into
Open
chore(analytics): remove dead Amplitude events and LISTEN_GATED#14304dylanjeffers wants to merge 3 commits into
dylanjeffers wants to merge 3 commits into
Conversation
Instruments three key contest interactions following the existing
'Remix Contest:' event prefix and {remixContestId, trackId} property
shape used by the host/pick-winners events:
- REMIX_CONTEST_VIEW: contest page/screen first resolves trackId+eventId
- REMIX_CONTEST_ENTER: user taps Enter Contest / Upload Remix
- REMIX_CONTEST_VIEW_SUBMISSIONS: user opens the submissions tab
Mobile submissions-tab firing uses useFocusedTab from
react-native-collapsible-tab-view because the contest tabs mount
eagerly (lazy: false) — a plain mount effect would fire even for
users who only view the Details tab.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…t sections Bug 1 (web): Align static explore section visibility with SearchResults render condition — hide sections when inputValue is set (during debounce window) in addition to when showSearchResults is true, so Premium and other filters applied via the filter pills always suppress unfiltered curated sections. Bug 2 (web): Guard empty-state tile behind !isPending in AlbumResultsPage and PlaylistResultsPage so the NoResultsTile is not shown while the query is still in its initial loading phase, preventing a spurious empty-state flash when combining "Downloads Available" + "Electronic" genre filters. Bug 3 (mobile): Include category !== 'all' in the showSearch guard on the explore screen so tapping a content-type pill (Tracks, Albums, etc.) immediately shows the filtered SearchResults without requiring a second filter to be added. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removes zero-callsite Name enum entries (COMMENTS_REPLY_TO_COMMENT, CREATOR_NODE_SELECTION, SEARCH_TAB_CLICK, SERVICE_MONITOR_HEALTH_CHECK, SERVICE_MONITOR_REQUEST, SIGN_UP_REPAIR_*), deprecated social OAuth signup events (CREATE_ACCOUNT_*_TWITTER/INSTAGRAM/TIKTOK), BUY_AUDIO family events replaced by BUY_USDC, LISTEN_GATED with its callsite and payload type, and ARTIST_COIN_PURCHASE/ARTIST_RECOMMENDATIONS_POPUP from FollowSource. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nameenum entries:COMMENTS_REPLY_TO_COMMENT,CREATOR_NODE_SELECTION,SEARCH_TAB_CLICK,SERVICE_MONITOR_HEALTH_CHECK,SERVICE_MONITOR_REQUEST,SIGN_UP_REPAIR_START/SUCCESS/FAILURECREATE_ACCOUNT_*_TWITTER,_INSTAGRAM,_TIKTOKvariants (enum entries, payload types, union members)BUY_AUDIOfamily events (BUY_AUDIO_SUCCESS,BUY_AUDIO_FAILURE,BUY_AUDIO_ON_RAMP_*,BUY_AUDIO_RECOVERY_*) replaced by BUY_USDC equivalentsLISTEN_GATEDfully: enum entry,ListenGatedpayload type, union member, and callsite inrecordListen.tsARTIST_COIN_PURCHASEandARTIST_RECOMMENDATIONS_POPUPfromFollowSourceenum and updates their callsites toFollowSource.OVERFLOW/FollowSource.USER_LISTTest plan
🤖 Generated with Claude Code