Fix HTTP/2 silent request timeouts under connection disruptions#2162
Merged
Conversation
hyperxpro
changed the title
hyperxpro
force-pushed
the
fix-semaphore-leak
branch
from
dd6f0bb to
1a64f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
~0.5% of HTTP/2 requests silently timed out under load (#2160):
Http2Handler.handleChannelInactive()/handleException()were no-ops, so in-flight stream futures were never failed on connection drop and hung to the request timeout.Modification:
Implement those handlers; fail requests queued in
pendingOpenerswhen the parent connection closes; make a single stream's RST/close stream-scoped (close=false) instead of tearing down the whole connection (RFC 7540 6.4); release the stream slot on post-open hook failures.Result:
In-flight and queued HTTP/2 requests fail fast on connection drop; one stream's RST no longer kills its siblings.