fix: forbidden override between generic function and concrete generic function#3014
Open
Changqing-JING wants to merge 2 commits intoAssemblyScript:mainfrom
Open
fix: forbidden override between generic function and concrete generic function#3014Changqing-JING wants to merge 2 commits intoAssemblyScript:mainfrom
Changqing-JING wants to merge 2 commits intoAssemblyScript:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3013 .
Changes proposed in this pull request:
In current assemblyscript,
Compile crashed
Error message
The output is different with typescript.
In typescript the output is
BBut in assemblyscript, the output is
AProposed solution
Assemblyscript can't follow typescript's behavior when override between generic and concrete generic function. Because typescript uses structural typing for type checking and erase type for code emitting.
But assemblyscript use nominal typing and need the type for code emitting. For example, in case 2, if assemblyscript need to follow typescript's behavior, it need a complex typing inference system to emit function B::foo. I don't think it's worth the effort
So this PR just totally forbidden override between generic function and concrete generic function