Migrated main to use embree3#2
Open
sante wants to merge 1 commit into
Open
Conversation
Owner
|
There are a lot of whitespace changes in this PR. That's the only reason I haven't merged it yet. There's a lot to look through. Thanks for porting it to embree 3. I may distil this to the essential changes if that's OK. |
sante
commented
Oct 19, 2020
Author
sante
left a comment
There was a problem hiding this comment.
Yes, you are right, I might have called the autoformatter of visual studio. If you want I can clean the changes so you don't have to
Owner
|
Thanks Agustin, if you can just have the changes needed for the PR that
would be great. I know it's a pain with these whitespace changes.
…On Mon, Oct 19, 2020 at 1:55 PM Agustin Santellan ***@***.***> wrote:
***@***.**** commented on this pull request.
Yes, you are right, I might have called the autoformatter of visual
studio. If you want I can clean the changes so you don't have to
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZ4GALAESVUNEBVV5VB23SLQZL5ANCNFSM4SFKHFKA>
.
|
Author
|
Will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Migration to embree 3 #1
Description:
Updated main file to use embree 3's new API
📌 Notes: