Skip to content

Migrated main to use embree3#2

Open
sante wants to merge 1 commit into
Arlorean:masterfrom
sante:master
Open

Migrated main to use embree3#2
sante wants to merge 1 commit into
Arlorean:masterfrom
sante:master

Conversation

@sante
Copy link
Copy Markdown

@sante sante commented Oct 6, 2020

Migration to embree 3 #1

Description:

Updated main file to use embree 3's new API

📌 Notes:

  • No changes were made to the visual studio solution, so the dependencies will have to be changed
  • The result is the same as the original, that was untouched too

@Arlorean
Copy link
Copy Markdown
Owner

There are a lot of whitespace changes in this PR. That's the only reason I haven't merged it yet. There's a lot to look through. Thanks for porting it to embree 3. I may distil this to the essential changes if that's OK.

Copy link
Copy Markdown
Author

@sante sante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, I might have called the autoformatter of visual studio. If you want I can clean the changes so you don't have to

@Arlorean
Copy link
Copy Markdown
Owner

Arlorean commented Oct 19, 2020 via email

@sante
Copy link
Copy Markdown
Author

sante commented Oct 19, 2020

Will do!

@Nestoter
Copy link
Copy Markdown

Agustin, watch out that the ported example it is generating a wrong image. It seems you changed the cube face colors for testing and forgot to revert them.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants