Antalya 26.3: add --jwt-command to client#1809
Conversation
zvonand
added
port-antalya
CI report: https://altinity-build-artifacts.s3.amazonaws.com/json.html?PR=1809&sha=02d52acedc65b24bf011bc1171266ea1ff8a5907&name_0=PR&name_1=Stateless+tests+%28amd_debug%2C+distributed+plan%2C+s3+storage%2C+parallel%29&name_2=Tests Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…e-token-in-client
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38da1d22e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…of github.com:Altinity/ClickHouse into feature/antalya-26.3/oauth-executable-token-in-client
…e-token-in-client
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
ClickHouse/programs/client/Client.cpp
Line 992 in d0ccc64
Reject --login when jwt-command is configured
This guard only checks config().has("jwt"), so a jwt-command coming from config.xml is not treated as conflicting with --login. In that case the --login path can run the interactive OAuth flow and set a JWT, and only later main fails with "jwt-command and jwt cannot both be specified". The conflict should be detected here as well (checking jwt-command too) so users get an immediate BAD_ARGUMENTS error without side effects.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
clickhouse-client: added--jwt-commandand --jwt-command-timeout, which invokes an external script to obtain a JWT for authentication; the script is re-invoked on every reconnect.CI/CD Options
Exclude tests:
Regression jobs to run: